Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

242 NPSP localized labels #7160

Merged
merged 5 commits into from
Dec 14, 2022
Merged

Conversation

dmkud
Copy link
Contributor

@dmkud dmkud commented Nov 30, 2022

Localized labels. The previously escaped single and double quotes were reverted back, probably because of the cli tool update. That should not be critical for the build

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

@balsamhindi
Copy link
Contributor

Have gotten the sign off that this can be merged in. As mentioned already there were some localization specific unit tests that came up after running the entire unit test suite. It has been determined it's nothing blocking, just mainly around specific string-based values in English vs. Other languages. An example is:

Message: System.AssertException: Assertion
                    Failed: The view state should retrieve the correct
                    Automation Lapsed Status: Expected: Lapsed, Actual:
                    Écoulé

This has been documented in a work item but there is no urgency to address in terms of blocking.

@balsamhindi balsamhindi merged commit f78f521 into feature/242 Dec 14, 2022
@balsamhindi balsamhindi deleted the feature/242__localization branch December 14, 2022 18:22
@balsamhindi balsamhindi restored the feature/242__localization branch December 14, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants