Update UpdaterTask.php #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Version to file
|
Not really needed... |
SalmonDE
requested changes
Nov 22, 2016
| file_put_contents('plugins/'.$this->name.'.phar', $file); | ||
| if(!file_exists('plugins/'.$this->name.'.phar')){ | ||
| file_put_contents('plugins/'.$this->name.' v'.$this->newversion.'.phar', $file); | ||
| if(!file_exists('plugins/'.$this->name.' v'.$this->newversion.'.phar')){ |
There was a problem hiding this comment.
could you replace the space with _? @opkiler22789
There was a problem hiding this comment.
@salmonger what's the difference? and so works
There was a problem hiding this comment.
@opkiler22789 hm wait, I think it's better to make them not havve the version in the name. Just to prevent that the plugin exists multiple times
|
Closing because I think it's better if the version name is not inside the filename due to the chance of having multiple files of the plugin. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Version to file