Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split native words #70

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Conversation

patricksurry
Copy link

Here's a first pass at #68. Most of the volume is still the core words but perhaps makes it easier to browse and navigate.
The native.asm file manages most of the conditional inclusion so that's not scattered as much throughout.
Both make and make taliforth-minimal.bin still work ok.

Not sure if I like the native_*.asm naming. An alternate would be to rename native.asm to words.asm and then have words/ folder containing the various pieces. Let me know what you think.

Here are the current line counts:

     254 native.asm
    1068 native_assembler.asm
     544 native_block.asm
    7655 native_core.asm
     560 native_disasm.asm
     298 native_double.asm
    1761 native_ed.asm
     265 native_editor.asm
     691 native_string.asm
    1169 native_tali.asm
     432 native_tools.asm
     530 native_wordlist.asm
   15227 total

@SamCoVT
Copy link
Owner

SamCoVT commented Apr 24, 2024

I think that looks pretty reasonable. Do you like native_xxxx.asm or words_xxxx.asm better? Tali used to have several words that were in Forth rather than assembly, which is where the difference between "native" and forth-defined words came from. All of the words were eventually assemblerized, so I don't know if that distinction is important anymore. They are still "native" in that Tali comes with them.

@patricksurry
Copy link
Author

patricksurry commented Apr 24, 2024 via email

@SamCoVT
Copy link
Owner

SamCoVT commented Apr 24, 2024

I like the idea of the "words" folder with the simple names based on wordlist.

I was thinking of updating the python script that generates docs/WORDLIST.md to also show the location of the word, but it already lists which wordset it comes from (taken from the specially formatted comments above words). There are a few oddballs, like words taken from gforth that aren't actually in the forth standard, but we can just update the comments for those few words and I think I would be happy with that. We can leave that as a future issue (if it even is an issue - the existing comments might be good enough) and not worry about it for this PR.

@SamCoVT SamCoVT merged commit af535e8 into SamCoVT:master-64tass Apr 28, 2024
@patricksurry patricksurry deleted the split-native branch April 28, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants