Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild Item Names Database slow and never resets #22

Closed
sliekens opened this issue Sep 19, 2015 · 2 comments
Closed

Rebuild Item Names Database slow and never resets #22

sliekens opened this issue Sep 19, 2015 · 2 comments

Comments

@sliekens
Copy link
Contributor

The button that lets you rebuild the item names database only starts rebuilding the database the first time that it is pressed. This is because the RebuildItemDatabase(...) method is invoked by the constructor of the RebuildNamesDatabaseViewModel, and the viewmodel is only instantiated once for the lifetime of the application.

Besides that, the entire process is kinda slow and could be sped up by using the paginated items endpoint and by handling tasks asynchronously.

@SamHurne SamHurne added the Issue label Sep 19, 2015
@SamHurne
Copy link
Owner

Funny, I was just noticing this myself...

See commits 8bcf466, e2bacc8, and 423777d.

@sliekens
Copy link
Contributor Author

I'd like to propose a cleaner solution than what you added in 8bcf466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants