Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.3.0: Multiplication #23

Merged
merged 4 commits into from
Sep 11, 2018
Merged

Version 0.3.0: Multiplication #23

merged 4 commits into from
Sep 11, 2018

Conversation

Samasaur1
Copy link
Owner

@Samasaur1 Samasaur1 commented Sep 11, 2018

Both Die and Dice can now be multiplied with Int. Examples:

let d6 = Die.d6
let threeD6 = d6 * 3
threeD6.debugDescription // 3d6

let dFourPlusFour = Die.d4 + 4
let threeTimesIt = dFourPlusFour * 3
threeTimesIt.debugDescription // 3d4 + 12

Version 0.2.0 additions also now have documentation (d70a925). These additions don't because they aren't documented at all.

Closes #10 and closes #11

@Samasaur1 Samasaur1 added this to the Multiplication milestone Sep 11, 2018
@Samasaur1
Copy link
Owner Author

Updating version...

@Samasaur1
Copy link
Owner Author

Samasaur1 commented Sep 11, 2018

Next steps:

  1. Wait for CI
  2. Merge
  3. git tag -s v0.3.0 -m "Version 0.3.0: The Multiplication Update"
  4. git push --tags
  5. git checkout development and git rebase master
  6. git push

@Samasaur1 Samasaur1 merged commit b145d43 into master Sep 11, 2018
@Samasaur1 Samasaur1 deleted the development branch September 11, 2018 18:55
@Samasaur1
Copy link
Owner Author

Because I did a squash merge instead of a merge commit, I deleted and recreated the development branch and then did a hard reset to it from my local repo to avoid a merge commit.

@Samasaur1
Copy link
Owner Author

I also forgot to say that I needed to close the Multiplication milestone, which I'm doing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More multiplication support Basic multiplication support
1 participant