-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diorama v2 "Myriorama" #38
Open
LBRDan
wants to merge
39
commits into
Sambego:master
Choose a base branch
from
LBRDan:dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er portal implementation
Still missing: Active preview on Speaker Notes (if willing to implement) and memoization on total step number
… without render prop) changed getTotalSteps to stepsCount (implicit getter and simple prop)
… passed up from nested Slide as it builds as child of Deck
Travis fails mainly because of Nodejs version in CI config (Node 10) - Some packages inside (such as Vitest) runs onto Node v14 or above Edit: Changed node_js version inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for your wonderful library! It's been inspiring to take a look inside this lib as much as attending your amazing speeches back in Verona @ JSDay this year 🚀
It all started when I tried to bake some interactivity inside a work PowerPoint presentation
I tried to enhance it a bit for my specific needs, but soon I found that someone else might benefit from these edits.
Also, it was an open-source exercise for me and the chance to get to work with the latest things in mind (ESM, Typescript Support, React 18, etc...)
Sure thing there is room for improvements and a lot of work to do, and lots of things could be done infinitely better than how I pulled it off...
This could be breaking not in the API itself, but some particular configuration for the end user bundler could get ESM/CJS choice a little bit trickier to update (maybe even the React upgrade itself can be tedious)
I'll list some of the Features packed inside:
MultistepSlide
component with multiple intermediate steps inside a singleSlide
(supports both children andrender
prop). To be used with custom slides, it can be used in tandem withMultiSlideContext
exported, avoiding props injection/drillingPresenterNotes
now takes advantage of React Portal: This ensures that all the Deck updates get captured correctly and keeps the presenter notes synchronized without manually poking it to catch up. Also, now PresenterNotes supports NavigationHud as well (I found it useful to manage the deck from the presenter note panel)Deck
props such asautomaticHistoryTrack
(useful when using custom SPA routers),initialPageIndex
(sets the current slide index on Deck's mount),onActiveSlideChange
(well, a callback to let the upper level in sync about the Slide in view)Again: there is a lot of room for improvement and I'm open to every suggestion you have to make this work for you
Thanks!