Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added L298N support and more #11

Merged
merged 2 commits into from
May 24, 2018
Merged

Added L298N support and more #11

merged 2 commits into from
May 24, 2018

Conversation

Lothean
Copy link
Contributor

@Lothean Lothean commented May 22, 2018

Added support for 4 L298N H bridges, expanded the note range, added a noteTicks array for other non-floppy instruments. (Arduino)
To switch to L298N mode, please refer to the MoppyCore.cpp file.
For pinout info, please refer to the L298N.h file.

Added support for 4 L298N H bridges, expanded the note range, added a noteTicks array for other non-floppy instruments.
@Lothean Lothean mentioned this pull request May 22, 2018
@Sammy1Am
Copy link
Owner

Would you mind adding the pinout information you posted above into L298N.h and add a comment near the instantiation in MoppyCore.cpp saying to see that file for pinout and additional info?

I think that might be the easiest way to keep all the new additions documented. The other option would be to use the repo wiki, but that might be more complicated organization-wise.

I'll add a bit of pinout / instructions to the FloppyDrives.h file, but I can cheat a bit and just link to the floppy drive instructions on the wiki :P

I'll also want to add in limits for the floppy drives now that you've got note data for higher notes, but I can do that after merging.

@Lothean
Copy link
Contributor Author

Lothean commented May 22, 2018

Done!

@Sammy1Am Sammy1Am merged commit df4d49d into Sammy1Am:master May 24, 2018
@ddagebi07 ddagebi07 mentioned this pull request Jun 18, 2022
hgrosic pushed a commit to hgrosic/Moppy2 that referenced this pull request Dec 29, 2022
* Added support for 4 L298N H bridges, expanded the note range, added a noteTicks array for other non-floppy instruments.
* Added pinout info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants