Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages updated #484

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Packages updated #484

merged 6 commits into from
Jan 4, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jan 3, 2024

Description

Please include a summary of the change and which is fixed.

  • Update packages for Python3.8 on 2024.01.03
  • Fix benchmark scores

How has this been tested?

Please describe the tests that you ran to verify your changes.

@babenek babenek changed the title CredData random seed for single line test Packages updated Jan 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (253b6ae) 90.41% compared to head (d5fcd80) 90.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
- Coverage   90.41%   90.40%   -0.01%     
==========================================
  Files         127      127              
  Lines        4328     4327       -1     
  Branches      693      693              
==========================================
- Hits         3913     3912       -1     
  Misses        274      274              
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rollback the custom reference after Samsung/CredData#64

.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
cicd/benchmark.txt Outdated Show resolved Hide resolved
cicd/benchmark.txt Outdated Show resolved Hide resolved
@babenek babenek marked this pull request as ready for review January 4, 2024 11:19
@babenek babenek requested a review from a team as a code owner January 4, 2024 11:19
Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@babenek babenek merged commit c231bd7 into Samsung:main Jan 4, 2024
29 checks passed
@babenek babenek deleted the rndlineseed branch January 4, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants