Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use LPVSFileUtil API for getReader #535

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

tiokim
Copy link
Member

@tiokim tiokim commented Jun 4, 2024

Pull Request

Description

It's refactored to use LPVSFileUtil API.
Unit tests of LPVSFileUtil have been updated to use assertEquals to improve accuracy.

Type of change

  • Code cleanup/refactoring

Testing

This PR is verified by the unit tests.

Test Configuration:

  • Java: v17
  • LPVS Release: v1.x.x

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Taewan Kim <t25.kim@samsung.com>
Signed-off-by: Taewan Kim <t25.kim@samsung.com>
Signed-off-by: Taewan Kim <t25.kim@samsung.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (4e31ac1) to head (5a86800).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #535      +/-   ##
============================================
- Coverage     92.70%   92.61%   -0.10%     
+ Complexity      530      528       -2     
============================================
  Files            48       48              
  Lines          1741     1733       -8     
  Branches        209      208       -1     
============================================
- Hits           1614     1605       -9     
- Misses           63       64       +1     
  Partials         64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov added the enhancement New feature or request label Jun 4, 2024
@o-kopysov o-kopysov added this to the v1.5.2 milestone Jun 4, 2024
Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov added this pull request to the merge queue Jun 4, 2024
@o-kopysov o-kopysov merged commit e989b32 into Samsung:main Jun 4, 2024
7 checks passed
@tiokim tiokim deleted the fileutil branch June 4, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants