-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use LPVSFileUtil API for getReader #535
Conversation
Signed-off-by: Taewan Kim <t25.kim@samsung.com>
Signed-off-by: Taewan Kim <t25.kim@samsung.com>
Signed-off-by: Taewan Kim <t25.kim@samsung.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
============================================
- Coverage 92.70% 92.61% -0.10%
+ Complexity 530 528 -2
============================================
Files 48 48
Lines 1741 1733 -8
Branches 209 208 -1
============================================
- Hits 1614 1605 -9
- Misses 63 64 +1
Partials 64 64 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request
Description
It's refactored to use LPVSFileUtil API.
Unit tests of LPVSFileUtil have been updated to use
assertEquals
to improve accuracy.Type of change
Testing
This PR is verified by the unit tests.
Test Configuration:
Checklist: