Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert/train] Let's introduce circle+ generating tools #12650

Closed
zetwhite opened this issue Feb 19, 2024 · 3 comments
Closed

[onert/train] Let's introduce circle+ generating tools #12650

zetwhite opened this issue Feb 19, 2024 · 3 comments

Comments

@zetwhite
Copy link
Contributor

zetwhite commented Feb 19, 2024

There is no way to create a circle+ file in public.
So, Let's generate tools for generating circle+, More exactly tools that inject training parameters into the circle file.

@zetwhite
Copy link
Contributor Author

zetwhite commented Feb 19, 2024

about draft

I made a draft (#12649) that injects training parameters into circle, referencing circle/oxri(inner source) implmentation.

I need more ideas 💡

After I made this draft work somehow, I started to think that it is NOT helpful because of the input format.

  • writing json file is troublesome
  • Also, getting input interactively might take too many times for users who want to modify only one value.

[ python API ]

IMHO, python API is more useful than command line executing tools.
But most of the tools in ONE are kinds of command line tools, so I'm hesitant to work on it.

#simple pseudo API 
import onert # new package

training_pram = onert.TrainingParameter(SGD(learning_rate = 0.01), MSE(from_logits=true), batch_size=32)

circle = onert.open("mnist.circle")
circle.inject_tparam(training_param)
circle.export("mnist_with_meta.circle")

/cc @Samsung/one_onert

@zetwhite
Copy link
Contributor Author

zetwhite commented Feb 28, 2024

After some talks with @Samsung/one_onert yesterday, I rethink this issue.

  • IMHO, It would be useful if this feature is provided in onecc-cmd. But it might take some time.
  • So, I'd like to add a tool that generates circle+ using a json file for now, and consider merging it into onecc later.

zetwhite added a commit to zetwhite/ONE that referenced this issue May 20, 2024
This PR adds a feature
 - add training parameters to a circle plus instance.
 - export circle plus instance as a *.circle file

ONE-DCO-1.0-Signed-off-by: seunghui youn <sseung.youn@samsung.com>

* related issue : Samsung#12650
zetwhite added a commit to zetwhite/ONE that referenced this issue May 27, 2024
This PR adds a feature
 - add training parameters to a circle plus instance.
 - export circle plus instance as a *.circle file

ONE-DCO-1.0-Signed-off-by: seunghui youn <sseung.youn@samsung.com>

* related issue : Samsung#12650
zetwhite added a commit to zetwhite/ONE that referenced this issue May 27, 2024
This PR adds a feature
 - add training parameters to a circle plus instance.
 - export circle plus instance as a *.circle file

ONE-DCO-1.0-Signed-off-by: seunghui youn <sseung.youn@samsung.com>

* related issue : Samsung#12650
zetwhite added a commit to zetwhite/ONE that referenced this issue May 27, 2024
This PR adds a feature
 - inject training parameters to a circle plus instance
 - export circle plus instance as a *.circle file

ONE-DCO-1.0-Signed-off-by: seunghui youn <sseung.youn@samsung.com>

* related issue : Samsung#12650
zetwhite added a commit to zetwhite/ONE that referenced this issue May 27, 2024
This PR adds a feature
 - inject training parameters to a circle plus instance
 - export circle plus instance as a *.circle file

ONE-DCO-1.0-Signed-off-by: seunghui youn <sseung.youn@samsung.com>

* related issue : Samsung#12650
@zetwhite
Copy link
Contributor Author

zetwhite commented Jun 4, 2024

basic features are all added in https://github.com/Samsung/ONE/tree/master/tools/circle_plus_gen.
So close this issue

@zetwhite zetwhite closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant