Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[one-optimize] Fuse mul with FC layer #13515

Closed
jinevening opened this issue Jul 25, 2024 · 7 comments
Closed

[one-optimize] Fuse mul with FC layer #13515

jinevening opened this issue Jul 25, 2024 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@jinevening
Copy link
Contributor

What

Let's fuse mul with preceding FC.

image

Whay

The pattern appears in fairseq decoder.

@jinevening jinevening added the good first issue Good for newcomers label Jul 25, 2024
@jiwaszki
Copy link
Contributor

Hi @jinevening , does "good first issue" label mean that the task is free to pick up?
If yes, could you assign it to me? I will start working on it right away.

@jinevening
Copy link
Contributor Author

does "good first issue" label mean that the task is free to pick up?

It means that the task is not too difficult (change is often limited to a single module) to start contribution to this project. You can pick a task from any open issue with no assignee. Sometimes issue owners forget to put assignees, so it would be better to leave a comment like you did in this issue.

I've assigned you to this issue. Thanks for contribution :)

Please read https://github.com/Samsung/ONE/wiki/ONE-Developer%27s-Certificate-of-Origin and https://github.com/Samsung/ONE/wiki/How-We-Work#pull-request before you post a PR.

@jiwaszki
Copy link
Contributor

@seanshpark as [luci/pass] is now merged, could you take a look at the rest of opened PRs? Thanks in advance!

@seanshpark
Copy link
Contributor

could you take a look at the rest of opened PRs? Thanks in advance!

Please fix the CI failures. You may have to rebase and push again.

@jiwaszki
Copy link
Contributor

@seanshpark PRs are now fixed: #13609 and #13608

@jiwaszki
Copy link
Contributor

@seanshpark #13609 , #13611 and #13612 are green now

@jinevening
Copy link
Contributor Author

It seems that all PRs are merged. Thanks! @jiwaszki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants