Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[one-cmds] Add an option for FuseMulWithFullyConnectedPass #13609

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

jiwaszki
Copy link
Contributor

@jiwaszki jiwaszki commented Aug 7, 2024

This commit adds one-cmd option for FuseMulWithFullyConnectedPass.

ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz j.iwaszkiewi@samsung.com

This commit adds one-cmd option for FuseMulWithFullyConnectedPass.

ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <j.iwaszkiewi@samsung.com>
@jiwaszki
Copy link
Contributor Author

jiwaszki commented Aug 7, 2024

@@ -171,6 +171,7 @@ Current transformation options are
- fuse_batchnorm_with_conv : This fuses BatchNorm operator to convolution operator
- fuse_batchnorm_with_dwconv : This fuses BatchNorm operator to depthwise convolution operator
- fuse_batchnorm_with_tconv : This fuses BatchNorm operator to transpose convolution operator
- fuse_mul_with_fullyconnected: This fuses Mul operator with the preceding FullyConnected operator if possible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix order

@@ -44,6 +44,7 @@ class CONSTANT:
'fuse_batchnorm_with_dwconv',
'fuse_batchnorm_with_tconv',
'fuse_activation_function',
'fuse_mul_with_fullyconnected',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix order

@@ -122,6 +123,7 @@ class CONSTANT:
('fuse_batchnorm_with_conv', 'fuse BatchNorm op to Convolution op'),
('fuse_batchnorm_with_dwconv', 'fuse BatchNorm op to Depthwise Convolution op'),
('fuse_batchnorm_with_tconv', 'fuse BatchNorm op to Transposed Convolution op'),
('fuse_mul_with_fullyconnected', 'fuse Mul op to FullyConnected op'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@seanshpark
Copy link
Contributor

will check/land after all dependent PRs has landed.

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit abcfcb5 into Samsung:master Aug 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants