DRAFT: Support circle+ training parameter loading #11740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetwhite
added
DRAFT
zetwhite
force-pushed
the
1017/circle-x-importer
branch
4 times, most recently
from
9120746
to
30171c5
Compare
zetwhite
commented
Oct 19, 2023
zetwhite
force-pushed
the
1017/circle-x-importer
branch
2 times, most recently
from
1a0ce64
to
df7a2c8
Compare
zetwhite
force-pushed
the
1017/circle-x-importer
branch
from
df7a2c8
to
03bdb51
Compare
zetwhite
force-pushed
the
1017/circle-x-importer
branch
from
81dcb91
to
59880de
Compare
zetwhite
force-pushed
the
1017/circle-x-importer
branch
from
ee885bc
to
f9002fc
Compare
zetwhite
commented
Oct 24, 2023
| @@ -235,6 +237,50 @@ void BaseLoader<LoaderDomain>::BaseLoader::loadFromFile(const std::string &file_ | |||
| close(_fd); | |||
| } | |||
|
|
|||
| template <typename LoaderDomain> | |||
| void BaseLoader<LoaderDomain>::BaseLoader::loadFromFile(const std::string &file_path, | |||
There was a problem hiding this comment.
can be merged with loadFromFile()
zetwhite
commented
Oct 24, 2023
| @@ -210,6 +224,7 @@ struct nnfw_session | |||
| std::vector<std::thread> _threads; | |||
| #ifdef ONERT_TRAIN | |||
| uint32_t _training_step{0}; | |||
| std::unique_ptr<onert::ir::train::TrainingInfo> _traininfo; | |||
There was a problem hiding this comment.
Is this a right place?
How about move to ir::Model.h ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve : #11692
ONE-DCO-1.0-Signed-off-by: SeungHui Youn sseung.youn@samsung.com