Draft-v2: Implement Circle+ Loader

[zetwhite]

related issue : #11692

ONE-DCO-1.0-Signed-off-by: SeungHui Youn sseung.youn@samsung.com

[jyoungyun]

How about using circlr+ word instead of traininfo ? Because this pr is for loading circle+ file format. :)

[zetwhite]

I intentionally choose the word traininfo instead of circle+.

Because circle+ range is a bit ambiguous.
What is circle+ exactly range?

• (1) both circle format and train info
• (2) only train info

I thought circle+ means (1).
But this loader mainly focuses on loading train info from metadata.
So, That's why I choose traininfo loader.

[jyoungyun]

I thought circle+ contains all meta information included in circle+ file format.
This circle+ loader loads all meta information from circle+ file. And each function can select the meta data it is interested in.

[zetwhite]

Oh, I see your point.

But still for me, the words "circle+ loader" look like it is responsible for loading both circle(subgraphs and tensors) and its metadata(train info and .. etc).

Therefore, How about the word circletr_meta_loader ?
+) I also thought the word circle+_meta_loader, but I'm afraid that string "+" cause trouble later.

[jyoungyun]

You can use different namespace for circle+ format.

[jyoungyun]

It would be better to check if there is a given parameter in main function instead of using _is_training_info variable.

[zetwhite]

I agree.

But for now, It is hard to check in the main.
Because Arg has a default value, It is hard to figure out whether the value is given or default in main.

ONE/tests/tools/onert_train/src/args.cc

Lines 212 to 222 in 8243c77

	("epoch", po::value<int>()->default_value(5)->notifier([&](const auto &v) { _epoch = v; }), "Epoch number (default: 5)")
	("batch_size", po::value<int>()->default_value(32)->notifier([&](const auto &v) { _batch_size = v; }), "Batch size (default: 32)")
	("learning_rate", po::value<float>()->default_value(0.001)->notifier([&](const auto &v) { _learning_rate = v; }), "Learning rate (default: 0.001)")
	("loss", po::value<int>()->default_value(0)->notifier([&] (const auto &v) { _loss_type = v; }),
	"Loss type\n"
	"0: MEAN_SQUARED_ERROR (default)\n"
	"1: CATEGORICAL_CROSSENTROPY\n")
	("optimizer", po::value<int>()->default_value(0)->notifier([&] (const auto &v) { _optimizer_type = v; }),
	"Optimizer type\n"
	"0: SGD (default)\n"
	"1: Adam\n")

[glistening]

@zetwhite Here are some points what I've talked you offline:

1. I would like to remove training info's default values from several difference places.
   (e.g. flatbuffers, command-line, API structure default, ...)
   It would be good to keep just 1 place (which is reasonable) or no place.
   For example, I think command-line tool (e.g. onert-train specifies training info to override default value, it may be good to remove all default values from command-line tool.

2. Training information timing needs to be determined.
   While the model itself is loaded during nnfw_load_..., training info was constructed in nnfw_train_prepare. Depending on this decision, the implementation will be changed.

3. Where to put circle_traininginfo.fbs and its generated file.
   I would like to create circlex_schema (or circle+_schema in the same level of circle_schema.).

[zetwhite]

@zetwhite Here are some points what I've talked you offline:

Thanks for the summary.

I found out how-to-append the loader on the current implementation wasn't clear. 😅
I'd better clarify the points and ask circle+'s member opinions offline.

[zetwhite]

(notes)

[zetwhite]

(notes)