Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Rename training ir Invalid to Undefined #12393

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

zetwhite
Copy link
Contributor

@zetwhite zetwhite commented Jan 2, 2024

This PR renames training IR's default value from 'Invalid' to 'Undefined'.
The word 'Undefined' is more appropriate in this case: If nobody sets training information(ir), training information is invalid because it is 'not defined' yet.

ONE-DCO-1.0-Signed-off-by: SeungHui Youn sseung.youn@samsung.com

@jyoungyun
Copy link
Contributor

The copyright year of the file should be updated to the 2024. :)

@jyoungyun
Copy link
Contributor

The copyright year of the file should be updated to the 2024. :)

Ah, this rule only applies to newly introduced files. :)

This PR renames training IR's default value from 'Invalid' to 'Undefined'.

The word 'Undefined' is more appropriate in this case:
If nobody sets training information(ir), training information is invalid because it is 'not defined' yet.

ONE-DCO-1.0-Signed-off-by: SeungHui Youn <sseung.youn@samsung.com>
@zetwhite zetwhite changed the title [onert/core] Rename training ir's Invalid to Undefined [onert] Rename training ir's Invalid to Undefined Jan 3, 2024
@zetwhite zetwhite marked this pull request as ready for review January 3, 2024 04:23
@zetwhite zetwhite added the PR/ready for review It is ready to review. Please review it. label Jan 3, 2024
@zetwhite zetwhite requested a review from a team January 3, 2024 04:24
@zetwhite zetwhite added the approval: 2 Require at least 2 approvals label Jan 3, 2024
@zetwhite zetwhite changed the title [onert] Rename training ir's Invalid to Undefined [onert] Rename training ir Invalid to Undefined Jan 3, 2024
Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoungyun jyoungyun requested a review from a team January 3, 2024 05:29
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit ffe1c24 into Samsung:master Jan 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: 2 Require at least 2 approvals PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants