Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Introduce BinaryArithmetic trainable operation #12495

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

Aeren1564
Copy link
Contributor

This commit introduces BinaryArithmetic train IR.

From draft #12417

This commit introduces BinaryArithmetic train IR.

Signed-off-by: YongHyun An <yonghyunz.an@samsung.com>
@Aeren1564 Aeren1564 mentioned this pull request Jan 18, 2024
3 tasks
@Aeren1564 Aeren1564 marked this pull request as ready for review January 18, 2024 07:01
Co-authored-by: Jiyoung Giuliana Yun <wldudyun10@gmail.com>
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit e02991a into Samsung:master Jan 22, 2024
9 checks passed
@Aeren1564 Aeren1564 deleted the add_trainable_add_op branch January 26, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants