Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Enable observer on execution #13155

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

hseok-oh
Copy link
Contributor

@hseok-oh hseok-oh commented Jun 11, 2024

This commit changes observer policy.
Before: Create enabled observer on compilation
After: Create possible observers on compilation, enable observer on execution

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh hseok82.oh@samsung.com


Related issue: #13039
Draft: #13013

Require merging #13151 and #13170 to not creating empty file when tracing observer and minmax observer is not used

@hseok-oh hseok-oh added PR/ready for review It is ready to review. Please review it. approval: 2 Require at least 2 approvals labels Jun 11, 2024
@hseok-oh hseok-oh requested a review from a team June 11, 2024 08:06
@hseok-oh hseok-oh marked this pull request as ready for review June 13, 2024 02:55
This commit changes observer policy.
Before: Create enabled observer on compilation
After: Create possible observers on compilation, enable observer on execution

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoungyun jyoungyun requested a review from a team June 13, 2024 05:25
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glistening glistening merged commit 8b33f84 into Samsung:master Jun 13, 2024
9 checks passed
@hseok-oh hseok-oh deleted the move_observer_enable branch June 14, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: 2 Require at least 2 approvals PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants