Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci/pass] Fix typos in FuseXxxToFC test #13449

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

seanshpark
Copy link
Contributor

This will fix typos in fuse Add/Mul to FullyConnected pass unit tests.

@seanshpark
Copy link
Contributor Author

from #13439 (comment)

@shs-park many thanks!!!

@seanshpark seanshpark requested a review from shs-park July 16, 2024 22:50
mhs4670go
mhs4670go previously approved these changes Jul 16, 2024
Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This will fix typos in fuse Add/Mul to FullyConnected pass unit tests.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
@seanshpark
Copy link
Contributor Author

@mhs4670go , PTAL again, I've updated FC weight size.

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
LGTM!
=)

@seanshpark
Copy link
Contributor Author

@mhs4670go PTAL

Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 8e5ad80 into Samsung:master Jul 17, 2024
7 checks passed
@seanshpark seanshpark deleted the luci_pass_fix_typo_fusetofc branch July 17, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants