-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onert] Introduce ExtraTensor #13576
Conversation
This PR introduces ExtraTensor. ExtraTensor means that the tensor is only used by one operation. ONE-DCO-1.0-Signed-off-by: seunghui youn <sseung.youn@samsung.com>
4c2d0da
to
ad9e40e
Compare
According to https://en.cppreference.com/w/cpp/language/rule_of_three, Rule of threeIf a class requires a user-defined destructor, a user-defined copy constructor, or a user-defined copy assignment operator, it almost certainly requires all three. Rule of fiveBecause the presence of a user-defined (or = default or = delete declared) destructor, copy-constructor, or copy-assignment operator prevents implicit definition of the move constructor and the move assignment operator, any class for which move semantics are desirable, has to declare all five special member functions: Could you follow the rule of five if move semantics are desirable for the class? |
I read the code wrong as user-defined copy constructor. You don't need to follow the rule unless there are user-defined special functions. |
@ragmani If so I'd like to get a review of this PR as it is. (+) About |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces ExtraTensor.
ExtraTensor means that the tensor is only used by one operation.
ONE-DCO-1.0-Signed-off-by: seunghui youn sseung.youn@samsung.com
draft : #13486
related : #13282