[onert/backend] Templatize MemoryPlannerFactory in train #13984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR templatize memory planner factory in train backend. MemoryPlannerFactory currently used for DisposableTensorIndex, but it will be also used for LayerScopeTensorIndex. ONE-DCO-1.0-Signed-off-by: seunghui youn <sseung.youn@samsung.com> draft : Samsung#13486 for : Samsung#13282
zetwhite
commented
Sep 11, 2024
| return instance; | ||
| } | ||
|
|
||
| // TODO: Update to use template varialbe instead of DisposableTensorIndex |
There was a problem hiding this comment.
This PR resolves this TODO.
MemoryPlannerFactory will be used for both LayerScopeTensorIdx and DisposableTensorIdx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR templatize memory planner factory in train backend. MemoryPlannerFactory currently used for DisposableTensorIndex, but it will be also used for LayerScopeTensorIndex.
ONE-DCO-1.0-Signed-off-by: seunghui youn sseung.youn@samsung.com
draft : #13486
for : #13282