[onert] Check Gather operand data type #14054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds operation validation for Gather to check operand data type. ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
glistening
reviewed
Sep 24, 2024
|
|
||
| const auto input_type = operandType(input_index); | ||
| if (input_type == DataType::QUANT_GGML_Q4_0 || input_type == DataType::QUANT_GGML_Q8_0) | ||
| OP_REQUIRES(isValidType(output_index, {DataType::FLOAT32})); |
There was a problem hiding this comment.
Maybe need to check output_type, not output_index.
There was a problem hiding this comment.
isValidType() get index to check type.
There was a problem hiding this comment.
Ah, isValidType uses index to check type. I didn't know. I confirmed isValidType checks the unerlying operand's type, not the parameter's type itself.
bool OperationValidator::isValidType(const OperandIndex &idx, const DataType &type)
{
return operandType(idx) == type;
}
bool OperationValidator::isValidType(const OperandIndex &idx,
std::initializer_list<DataType> valid_types)
{
for (auto &&type_to_check : valid_types)
{
if (isValidType(idx, type_to_check))
{
return true;
}
}
return false;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds operation validation for Gather to check operand data type.
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh hseok82.oh@samsung.com