[luci/service] Fix dynamic shape inference for reshape operation #14061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHATWhen I optimize the following circle: I get this which has wrong output shape: WHYThe original code always infers HOWInfer |
jongwonyang
added
the
PR/ready for review
seanshpark
reviewed
Sep 24, 2024
This commit prevents shape inference when the reshape tensor's dimensions are not fully known. ONE-DCO-1.0-Signed-off-by: Jongwon Yang <yjw963@gmail.com>
jongwonyang
force-pushed
the
reshape-should-infer
branch
from
790376e
to
54a1bcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents shape inference when the reshape tensor's dimensions are not fully known.
Related: #13927
Draft: #13999
ONE-DCO-1.0-Signed-off-by: Jongwon Yang yjw963@gmail.com