[Draft] Revise RemoveUnnecessaryTransposeNetPass #14121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR Simplifies TaggedShapeAnaylzer in RemoveUnnecessaryTransposeNetPass. ONE-DCO-1.0-Signed-off-by: seunghui youn <sseung.youn@samsung.com>
This commit move luci::CircleNode into TaggedShapeAnalyzer
|
related : #13663 |
zetwhite
added a commit
to zetwhite/ONE
that referenced
this pull request
Sep 30, 2024
This PR simplify TaggedShapeAnalyzer in RemoveUnnecessaryTransposeNetPass. By removing less-related code(flatzize(), inference_incomplete_shape()) in TaggedShapeAnaylzer, This PR clearfy TaggedShapeAnaylzer's role. ONE-DCO-1.0-Signed-off-by: seunghui youn <sseung.youn@samsung.com> * draft : Samsung#14121 (background) Before resolving Samsung#13663, I'd like to trim current RemoveUnnecessaryTransposeNetPass.
This was referenced Sep 30, 2024
zetwhite
commented
Oct 2, 2024
Comment on lines
+367
to
+375
| { | ||
| reset_tag(_out_shape); | ||
|
|
||
| analyze_transpose(reverse_perm(_back_perm)); | ||
|
|
||
| analyze_transpose<DType>(b_tr); | ||
| auto shape = extract_shape(_front_transpose); | ||
| RET_FALSE_UNLESS(analyze_reshape(shape)); | ||
|
|
||
| analyze_transpose(reverse_perm(_front_perm)); |
There was a problem hiding this comment.
- if
out_rank > in_rank, analyze it in reverse order :- set_tag(
output_shape) - analyze(
back_transponse) - analyze(
mid_resahpe) - analyze(
front_transpose)
- set_tag(
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Draft
ONE-DCO-1.0-Signed-off-by: seunghui youn sseung.youn@samsung.com