[res] Add TFLiteRecipe for non-const reshape #14139
Conversation
jongwonyang
added
PR/ready for review
This commit adds TFLiteRecipe for reshape which has non-const shape. ONE-DCO-Signed-off-by: Jongwon Yang <yjw963@gmail.com>
jongwonyang
force-pushed
the
reshape-recipe
branch
from
62ee74b
to
4817e55
Compare
|
@jongwonyang, |
|
The PR is ready now :) |
| operation { | ||
| type: "Add" | ||
| input: "add_const_1" | ||
| input: "add_const_2" | ||
| output: "add_out" | ||
| add_options { | ||
| activation: NONE | ||
| } | ||
| } |
There was a problem hiding this comment.
This recipe contains another operation - Add, in addition to the Reshape operation.
What case was it created to test?
A recipe that combines multiple operations like this usually uses the prefix Net_,
for example, Net_TConv_Add_000.
There was a problem hiding this comment.
This recipe is for models that have non-constant shape input.
This recipe supposed to be introduced along with the issue #1519,
but revised with the discussion #13927 (comment),
so I thought that it would be more appropriate to name it to Reshape_005 since it's not related to specific operation (like Add).
There was a problem hiding this comment.
Thanks for the explanation!
There was a problem hiding this comment.
Reshape_005 is OK and
also Net_blabla is also OK to me as this recipe has more than one type of Ops.
This commit adds TFLiteRecipe for reshape which has non-const shape.
Related: #1519
ONE-DCO-Signed-off-by: Jongwon Yang yjw963@gmail.com