Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci] Shape/Type inference for gather #210

Merged
merged 2 commits into from
Apr 23, 2020
Merged

[luci] Shape/Type inference for gather #210

merged 2 commits into from
Apr 23, 2020

Conversation

llFreetimell
Copy link
Contributor

Parent Issue : #94
Full Draft : #113

This commit will add shape and type inference for gather operation

Signed-off-by: llFreetimell seok9311@naver.com

This commit will add shape and type inference for `gather` operation

Signed-off-by: llFreetimell <seok9311@naver.com>
@jinevening
Copy link
Contributor

The issue seems to be the comparison between int and unsigned. You can check the issue during compilation if you set ENABLE_STRICT_BUILD=ON when configuring nncc.

./nncc configure -DENABLE_STRICT_BUILD=ON

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 88c1e4d into Samsung:master Apr 23, 2020
@llFreetimell llFreetimell deleted the luci_gather_inference branch April 23, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants