Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onert] Add Keyfunction to IPortableTensor to resolve NDK's dynamic_cast issue #4341

Merged
merged 1 commit into from
Sep 21, 2020
Merged

[onert] Add Keyfunction to IPortableTensor to resolve NDK's dynamic_cast issue #4341

merged 1 commit into from
Sep 21, 2020

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Sep 18, 2020

@dayo09 dayo09 requested a review from wateret September 18, 2020 02:36
@hyunsik-yoon
Copy link
Contributor

I wonder if we can have something like ~Tensor() = default; in .h file instead of introducing an empty body in a separate .cc file. Could you explain the reason a bit? Thanks.

wateret
wateret reviewed Sep 18, 2020
View reviewed changes
runtime/onert/core/src/backend/cpu_common/Tensor.cc
@@ -26,7 +26,7 @@ namespace backend
namespace cpu_common
{

Tensor::~Tensor() = default;
Tensor::~Tensor() {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought those are same.

wateret
wateret approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@wateret wateret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wateret
Copy link
Member

wateret commented Sep 18, 2020 •
edited
Loading

I wonder if we can have something like ~Tensor() = default; in .h file instead of introducing an empty body in a separate .cc file. Could you explain the reason a bit? Thanks.

@hyunsik-yoon This is intended, just to create a key function. Please refer to #4157 (and android/ndk#533 (comment)).

@hyunsik-yoon
Copy link
Contributor

@wateret Ah. non-inlined. Thanks. :-)

periannath
periannath approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@periannath periannath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 8b16b69 into Samsung:master Sep 21, 2020
periannath added a commit to periannath/ONE that referenced this pull request Sep 21, 2020
@periannath
[onert] Enable dynamic_cast assert for android in polymorphic_downcast
bc7800d 
- This commit enables dynamic_cast assert for android in polymorphic_downcast
  - Check for `__ANDROID__` macro is added to avoid assertion Samsung#3654
  - dynamic_cast now works well on android Samsung#4341

ONE-DCO-1.0-Signed-off-by: JiHwan Yeo <jihwan.yeo@samsung.com>
@periannath periannath mentioned this pull request Sep 21, 2020
Merged
hseok-oh pushed a commit that referenced this pull request Sep 21, 2020
@periannath
[onert] Enable dynamic_cast assert for android in polymorphic_downcast (
02b6088 
#4349)

- This commit enables dynamic_cast assert for android in polymorphic_downcast
  - Check for `__ANDROID__` macro is added to avoid assertion #3654
  - dynamic_cast now works well on android #4341

ONE-DCO-1.0-Signed-off-by: JiHwan Yeo <jihwan.yeo@samsung.com>
@dayo09 dayo09 deleted the PR-keyfunction branch January 27, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wateret wateret wateret approved these changes

@periannath periannath periannath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dayo09 @hyunsik-yoon @wateret @periannath @hseok-oh