Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[luci] Separate testhelper from pass #6335

Merged
merged 1 commit into from
Mar 28, 2021
Merged

[luci] Separate testhelper from pass #6335

merged 1 commit into from
Mar 28, 2021

Conversation

seanshpark
Copy link
Contributor

This will separate test graph builder from pass to independent module.

ONE-DCO-1.0-Signed-off-by: SaeHie Park saehie.park@gmail.com

@seanshpark
[luci] Separate testhelper from pass
793b30a 
This will separate test graph builder from pass to independent module.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
@seanshpark
Copy link
Contributor Author

From draft #6231
Existing codes in pass will be removed someday...

mhs4670go
mhs4670go reviewed Mar 26, 2021
View reviewed changes
compiler/luci/testhelper/include/luci/test/TestIOGraph.h
}

public:
virtual void init(loco::Graph *g, const ShapeU32 shape_in)
Copy link
Contributor

@mhs4670go mhs4670go Mar 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(suggestion) It would be better if we can initialize each input's shape individually because there's a lot of graph whose inputs don't have the same shape. And so would TestOsGraphlet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll revise this in the draft :)

mhs4670go
mhs4670go approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jinevening
jinevening approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hyunjun85
Hyunjun85 approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@Hyunjun85 Hyunjun85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@seanshpark seanshpark merged commit 774c216 into Samsung:master Mar 28, 2021
@seanshpark seanshpark deleted the luci_testhelper branch March 28, 2021 21:39
@seanshpark seanshpark mentioned this pull request Mar 29, 2021
Merged
@dayo09 dayo09 mentioned this pull request Apr 6, 2021
Closed
@dayo09
Copy link
Contributor

dayo09 commented Apr 6, 2021 •
edited
Loading

@seanshpark Is this available?
I have tried to use this instead of compiler/luci/pass/src/test/TestIOGraph.h, segfault occurred 😢

luci::test::TestIOGraph::output()->from(node) has caused the segfault.

(ADDED) I see that compiler/luci/partition/src/PartitionPModules.test.cpp and other tests run well... I will examine more. 🌵

/nfs/git/ONE  ➦ ee117711 ±  coredumpctl dump 
           PID: 442 (luci_pass_test)
           UID: 1000 (dayo)
           GID: 1000 (dayo)
        Signal: 11 (SEGV)
     Timestamp: Tue 2021-04-06 19:07:48 KST (3min 15s ago)
  Command Line: ./build/compiler/luci/pass/luci_pass_test
    Executable: /nfs/git/ONE/build/compiler/luci/pass/luci_pass_test
 Control Group: /user.slice/user-1000.slice/user@1000.service/gnome-terminal-server.service
          Unit: user@1000.service
     User Unit: gnome-terminal-server.service
         Slice: user-1000.slice
     Owner UID: 1000 (dayo)
       Boot ID: 9e9bb3d3f5ac4dc693f383a9df9f97d8
    Machine ID: af68a111f0924ae79fe2f70cfad85e43
      Hostname: dayo-400T8A-400S8A
       Storage: /var/lib/systemd/coredump/core.luci_pass_test.1000.9e9bb3d3f5ac4dc693f383a9df9f97d8.442.1617703668000000.lz4
       Message: Process 442 (luci_pass_test) of user 1000 dumped core.
                
                Stack trace of thread 442:
                #0  0x00007f97795b2f42 _ZNKSt4lessIPN4loco3UseEEclERKS2_S5_ (libloco.so)
                #1  0x00007f97795b2e0a _ZNSt8_Rb_treeIPN4loco3UseES2_St9_IdentityIS2_ESt4lessIS2_ESaIS2_EE14_M_lower_boundEPSt13_Rb_tree_nodeIS2_EPSt18_Rb_tree_node_baseRKS2_ (libloco.so)
                #2  0x00007f97795b2adc _ZNSt8_Rb_treeIPN4loco3UseES2_St9_IdentityIS2_ESt4lessIS2_ESaIS2_EE4findERKS2_ (libloco.so)
                #3  0x00007f97795b29a0 _ZNSt3setIPN4loco3UseESt4lessIS2_ESaIS2_EE4findERKS2_ (libloco.so)
                #4  0x00007f97795b2864 _ZN4loco3Use4nodeEPNS_4NodeE (libloco.so)
                #5  0x000055abba6d79a9 _ZN4luci12CircleOutput4fromEPN4loco4NodeE (luci_pass_test)
                #6  0x000055abba73aa9a init (luci_pass_test)
                #7  0x000055abba73b0ae _ZN40QuantizedModelVerifierTest_Logistic_Test8TestBodyEv (luci_pass_test)
                #8  0x000055abbb0c9b08 n/a (n/a)
Refusing to dump core to tty (use shell redirection or specify --output).
(py369)  ✘ dayo  /nfs/git/ONE  ➦ ee117711 ± 

@seanshpark
Copy link
Contributor Author

I have tried to use this instead of compiler/luci/pass/src/test/TestIOGraph.h, segfault occurred

Old one may caused some confusion. I'll work on removing the old one :)

@dayo09 dayo09 mentioned this pull request Apr 7, 2021
Closed
@seanshpark seanshpark mentioned this pull request Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyunjun85 Hyunjun85 Hyunjun85 approved these changes

@llFreetimell llFreetimell llFreetimell approved these changes

@mhs4670go mhs4670go mhs4670go approved these changes

@jinevening jinevening jinevening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@seanshpark @dayo09 @jinevening @mhs4670go @llFreetimell @Hyunjun85