Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - Assertion `s <= e' failed in Escargot::StringView::StringView #238

Merged
merged 1 commit into from
May 7, 2019

Conversation

kisbg
Copy link
Contributor

@kisbg kisbg commented May 6, 2019

related #237

Signed-off-by: bence gabor kis kisbg@inf.u-szeged.hu

Copy link
Contributor

@ksh8281 ksh8281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clover2123
Copy link
Contributor

Would you add a internal TC related to #237? Thanks.

related Samsung#237

Signed-off-by: bence gabor kis <kisbg@inf.u-szeged.hu>
@kisbg
Copy link
Contributor Author

kisbg commented May 7, 2019

TC has been added

Copy link
Contributor

@clover2123 clover2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi yichoi merged commit 6e76ed1 into Samsung:master May 7, 2019
@kisbg kisbg deleted the bugfix-237 branch March 12, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants