Devel #17
Devel #17
Conversation
Samuel-Tyler
commented
Jan 26, 2020
•
Samuel-Tyler
commented
- Improve parser
- Add DefaultType
- Allow circular Choices
- Bug fixes and testing improvements
- Add conan
- Add fast_ber_view
- Reorganize test cases
- Add optimized BerContainers, use as a base for ber types
- Correct comment parsing issue
Add REAL type support
| @@ -1914,7 +1914,7 @@ re2c:define:YYCURSOR = "context.cursor"; | |||
| { context.location.columns(context.cursor - start); return yylex(context); } | |||
| "--" ([\-]?[^\r\n\-])*[\-]? | |||
| { context.location.columns(context.cursor - start); return yylex(context); } | |||
| "/*" ([^\*]|[\*][^/])* "*/" | |||
| "/*" ([^\*]|([\*]+[^\*\/]))*[\*]+ "/" | |||
There was a problem hiding this comment.
I'm sure it's a good fix, do you have an example of the problem we could add to testfiles?
https://github.com/Samuel-Tyler/fast_ber/tree/master/testfiles
(Just to prevent it happening in future)
There was a problem hiding this comment.
Another small point is that the file src/compiler/autogen_copy/asn_compiler.hpp must be updated when .yacc is updated. This is a copy used for windows builds where bison does not run.
I will push an updated file.
There was a problem hiding this comment.
I'm sure it's a good fix, do you have an example of the problem we could add to testfiles?
https://github.com/Samuel-Tyler/fast_ber/tree/master/testfiles
(Just to prevent it happening in future)
A comment written like this made the compiler segfault:
/************
-- OIDs
************/
Adding a space before the closing tag made the compiler working without an issue:
/************
-- OIDs
*********** */
The new regex accepts both comments without segfault
|
@kurkpitaine Are you happy for this to me merged or do you have pending changes? I would like to make a release 0.4 |
I'm ok to merge the modifications 👍 |
