Support pasting code #10
Conversation
|
Nice work! Definitely a necessary improvement. |
| var newContentState = Draft.Modifier.splitBlock(contentState, selection); | ||
| return Draft.EditorState.push(editorState, newContentState, 'split-block'); | ||
| editorState = splitBlock(editorState); | ||
| editorState = setUnstyled(editorState); |
There was a problem hiding this comment.
The double split-block creates two history items on the undo stack for what's really one atomic operation.
After cmd-returning out of a code-block, you'll need to hit cmd-z (undo) twice to get back to where you were. Hopefully one day draft-js will have a convenient way of grouping operations into a single stack item.
I made helper functions insertBlockBefore and insertBlockAfter (current selection) for this reason which only create a single history stack item: https://gist.github.com/danneu/33eb706be229f5e4b71204b837aff822
So one idea is to use that insertBlockAfter helper instead of the double-split. It also moves the selection to the inserted block.
|
Hey @whitejava are you going to update this PR with the changes requested above? Would be awesome to land this! |
When you paste code, you will get:
But I expect this:
This MR makes pasting better.