Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp: Separate Conversion of Number Type and Currency Type #4

Closed
Samyeak opened this issue Jan 19, 2020 · 1 comment
Closed

Revamp: Separate Conversion of Number Type and Currency Type #4

Samyeak opened this issue Jan 19, 2020 · 1 comment
Assignees
@Samyeak
Labels
enhancement New feature or request

Comments

@Samyeak
Copy link
Owner

Samyeak commented Jan 19, 2020

Feature: Separate Conversion for Numbers and Currencies

  • Completely rewrite the main class and separate data and logic.
  • Add different classes for Number and Currency Conversion each.
  • Add Options Class to define user options for number and currency each.
  • Rewrite the whole namespaces.
  • Add Provision for application level configuration.
@Samyeak Samyeak added the enhancement New feature or request label Jan 19, 2020
@Samyeak Samyeak self-assigned this Jan 19, 2020
Samyeak added a commit that referenced this issue Jan 19, 2020
@Samyeak
Renamed Project to NumericWordsConversion | Added NumberConverter | T…
c6d1ebd 
…ask #4
Samyeak added a commit that referenced this issue Jan 19, 2020
@Samyeak
Added common conversion processes to Conversion Factory and added new…
e2b11c2 
… Process for CCurrency Factory | Task #4
Samyeak added a commit that referenced this issue Feb 1, 2020
@Samyeak
Added Application Level Configuration and Revamped Extension Functions |
27fd4bb 
Task #4
Samyeak added a commit that referenced this issue Feb 1, 2020
@Samyeak
Updated readme, deleted obsolute files and also modified unit tests w…
ddf36e5 
…orkflow to run in release and pull requests too | Task #4
@Samyeak
Copy link
Owner Author

Samyeak commented Feb 1, 2020

Merged with develop and master #5 #6

@Samyeak Samyeak closed this as completed Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Samyeak Samyeak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Samyeak