Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added minecraft.DefaultProtocol() #153

Merged
merged 5 commits into from
Oct 4, 2022
Merged

added minecraft.DefaultProtocol() #153

merged 5 commits into from
Oct 4, 2022

Conversation

Blackjack200
Copy link
Contributor

useful for multi-protocol API

@Superomarking
Copy link

fr !!

Sandertv
Sandertv reviewed Sep 24, 2022
View reviewed changes
Copy link
Owner

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is a good idea. I've added one thing I'd recommend changing.

Sandertv
Sandertv reviewed Sep 24, 2022
View reviewed changes
minecraft/protocol.go Outdated Show resolved Hide resolved
Sandertv
Sandertv reviewed Sep 27, 2022
View reviewed changes
minecraft/protocol.go Outdated Show resolved Hide resolved
Sandertv
Sandertv approved these changes Oct 4, 2022
View reviewed changes
Copy link
Owner

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@Sandertv Sandertv merged commit 603fc82 into Sandertv:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandertv Sandertv Sandertv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blackjack200 @Superomarking @Sandertv