Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Hebrew translation #82

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Feature/Hebrew translation #82

merged 6 commits into from
Oct 10, 2023

Conversation

TomerPacific
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Added Hebrew translation

Featured Covered in this PR

  • Creating app_he.arb file and adding translations there
  • Adding Locale in app.dart

Related Tickets & Documents

Screenshots, Recordings

qemu-system-x86_64_5UrKlZhNDu

qemu-system-x86_64_j2zDsoNUyr

Tested Feature??

  • In Real Device.
  • In Emulator

Copy link
Owner

@SankethBK SankethBK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you check the linter error. I think its because this line exceeds 80 characters

          supportedLocales: const [Locale('en'), Locale('hi'), Locale('pa'), Locale('he')],

@TomerPacific
Copy link
Contributor Author

Sure @SankethBK . Would you like me to just break that line into two?

@SankethBK
Copy link
Owner

Sure @SankethBK . Would you like me to just break that line into two?

@TomerPacific you can add a trailing comma after Locale('he'), it will break the array into multiple lines

@SankethBK
Copy link
Owner

@TomerPacific it would be like this after formatting

          supportedLocales: const [
            Locale('en'),
            Locale('hi'),
            Locale('pa'),
            Locale('he'),
          ],

@SankethBK
Copy link
Owner

LGTM, thanks for your contribution

@SankethBK SankethBK merged commit d8f7cee into SankethBK:master Oct 10, 2023
2 checks passed
@TomerPacific TomerPacific deleted the feature/hebrew-translation branch October 10, 2023 14:56
SankethBK pushed a commit that referenced this pull request Oct 20, 2023
* feature/hebrew-translation creating hebrew translations file and translating half
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants