Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in documentation for gel_fit model #538

Closed
smk78 opened this issue Nov 9, 2022 · 0 comments · Fixed by #541
Closed

Error in documentation for gel_fit model #538

smk78 opened this issue Nov 9, 2022 · 0 comments · Fixed by #541

Comments

@smk78
Copy link
Contributor

smk78 commented Nov 9, 2022

User ZhouQ noticed the following about the gel_fit model:

From your manual, the scattered intensity is provided by
image
However, from Shibayama’s paper, the Lorentzian part is given by
image
Considering that when D = 2, the Lorentzian part will be reduced to the Ornstein-Zernicke equation, as you and Shibayama mentioned, I believe the bottom form is correct. But I am unsure whether it is a typo in the manual or an incorrect expression that may affect the fitting results (a bug?).

Examination of the source code shows:

     // Lorentzian Term
    ////////////////////////double a(x[i]*x[i]*zeta*zeta);
    double lorentzian_term = square(q*cor_length);
    lorentzian_term = 1.0 + ((fractal_dim + 1.0)/3.0)*lorentzian_term;
    lorentzian_term = pow(lorentzian_term, fractal_dim/2.0 );

which corresponds with the lower (Shibayama) expression so the formatting of the expression in the model doc string needs revising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant