Ensure that the dll tests clean up after themselves #525
Conversation
llimeht
force-pushed
the
tmp/model-cleanup
branch
from
b7120d7
to
c639f04
Compare
| try: | ||
| os.remove(derived_model.dllpath) | ||
| except Exception: | ||
| pass |
There was a problem hiding this comment.
Thinking about why you need the try/except I realize it's because you may not have a dll path associated with the kernel, if it is a cuda kernel for example. Which begs the question of why dllpath is part of the "public" interface. We should probably rename it to _dllpath in the kerneldll.py so that you can't do this operation.
Instead we should have a clean method as part of the kernel API for removing the cache for one-offs like this, and this method can reference _dllpath.
Feel free to move this action to a new "clean" method, or merge this as is and add a ticket to address the technical debt.
|
Cache-invalidation and cleanup are always complicated. It's not entirely clear to me what the correct behaviour is for the sasmodels cache: what gets cached, what is "prepopulated" into the cache, what is not cached, what cleans out the cache as it grows forever... Figuring out the use cases and the requirements might be a good thing for a separate discussion. |
One of the model tests (
direct_model.py::test_reparameterize) leaves behind stray files from the compiled DLLs, this PR tries to cleanup.