ESS GUI: Warn user when data set fully masked #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkienzle
approved these changes
Feb 4, 2020
|
Jeff to test GUI -- then approve .. .or not. |
…ror message sent to the console. The existing message is not used once it created.
|
The 1st PR merge (#1368) that loaded in the mask was reverted along with a few other changes in a recent commit. I've restored that change here. Also, I changed DataExplorer to better handle errors linked to loaded data sets. The current behavior reads the errors and creates a string out of them, but the string isn't used anywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR matches 5.x up to the 4.x branch by attaching a warning to any data set that is fully masked when it is loaded. The first of the two commits has already been merged into the ESS_GUI branch, but the 2nd commit (cherry-picked here) has not.
The PR for the 4.x branch: #1356
The 1st PR for the 5.x branch: #1368