Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2885 logos do not appear in about box #2894

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

lucas-wilkins
Copy link
Contributor

Fixes #2885 - icons not appearing

  • Also updated the icons for the insitutions, many now SVGs.
  • Reworked the box a little
  • Minor change to some menu text

@lucas-wilkins lucas-wilkins added Discuss At The Call Issues to be discussed at the fortnightly call SasView 6.0.0 Required for 6.0.0 release labels Jun 11, 2024
@lucas-wilkins lucas-wilkins linked an issue Jun 13, 2024 that may be closed by this pull request
Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the installer on Windows. The images are bundled properly and show up in the about box. The window is also cleaner to look at.

One suggestion - the new buttons give no hover feedback they are links. I only knew they were because of the code.

@lucas-wilkins
Copy link
Contributor Author

One suggestion - the new buttons give no hover feedback they are links. I only knew they were because of the code.

I can fix that, probably

@lucas-wilkins
Copy link
Contributor Author

@krzywon There were some limitations on what kind of feedback works, as image handling in Qt is pretty unpredictable and the logos are all different sizes and formats. Hope just removing the border is enough.

@wpotrzebowski
Copy link
Contributor

wpotrzebowski commented Jun 25, 2024

Tested on Mac. It looks nice (much nicer than the previous one). Maybe 6.0.0b1 font can be slightly bigger.

The question is if we should add more logos to match updated contributors list? This will make this box probably too big and I am thinking if it is not better to skip the logos and just refer yo people list on website.
Screenshot 2024-06-25 at 06 05 54

@butlerpd
Copy link
Member

butlerpd commented Jul 2, 2024

check and see if we are missing any logos that really need to be added.

@krzywon krzywon merged commit 40a3ad0 into release_6.0.0 Jul 12, 2024
28 checks passed
@krzywon krzywon deleted the 2885-logos-do-not-appear-in-about-box-1 branch July 12, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discuss At The Call Issues to be discussed at the fortnightly call SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logos do not appear in about box
4 participants