-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2885 logos do not appear in about box #2894
2885 logos do not appear in about box #2894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the installer on Windows. The images are bundled properly and show up in the about box. The window is also cleaner to look at.
One suggestion - the new buttons give no hover feedback they are links. I only knew they were because of the code.
I can fix that, probably |
…hub.com/SasView/sasview into 2885-logos-do-not-appear-in-about-box-1
@krzywon There were some limitations on what kind of feedback works, as image handling in Qt is pretty unpredictable and the logos are all different sizes and formats. Hope just removing the border is enough. |
check and see if we are missing any logos that really need to be added. |
Fixes #2885 - icons not appearing