Implement Table read with pagination #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2019
|
test output with role PR #290 and SatelliteQE/robottelo#6751 |
abalakh
reviewed
Feb 21, 2019
| @@ -1267,6 +1287,96 @@ def read(self): | |||
| "return ace.edit('{0}').getValue();".format(self.ace_edit_id)) | |||
|
|
|||
|
|
|||
| class Pagination(Widget): | |||
There was a problem hiding this comment.
I'm not so sure that's the right place for this widget. Patternfly defines a standard for paginator, so such widget should lie under widgetastic_patternfly and we should just import it. If satellite has slightly different locators - then original widget in widgetastic_patternfly, and on our end we should inherit and only update locators accordingly.
|
tested also with content view by creating 93 entities (and triggering all the buttons): def read_all(self, per_page=None):
view = self.navigate_to(self, 'All')
if per_page:
view.table.pagination.per_page.fill(per_page)
view.table.pagination.last_page()
view.table.pagination.previous_page()
return view.table.read()the tests passed as expected |
oshtaier
previously approved these changes
Feb 25, 2019
|
created an issue at widgetastic.patternfly RedHatQE/widgetastic.patternfly#84 |
ldjebran
force-pushed
the
implement_table_pagination
branch
from
29c3f0d
to
1892ed2
Compare
|
@abalakh @oshtaier changes done test katello entity class ContentViewEntity(BaseEntity):
def read_all(self, per_page=None):
view = self.navigate_to(self, 'All')
if per_page:
view.table.pagination.per_page.fill(per_page)
view.table.pagination.last_page()
view.table.pagination.previous_page()
return view.table.read()def test_content_view_read_all(session, module_org):
for _ in range(63):
entities.ContentView(organization=module_org).create()
with session:
values = session.contentview.read_all(per_page='25')
assert len(values) == 63 |
oshtaier
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test output with regular tests
to test the pagination and read_all created some function and test:
test output