Updates to New Host UI Traces tab #821
Conversation
| self.browser.plugin.ensure_page_safe() | ||
| view.traces.enable_traces.click() | ||
| modal = EnableTracerView(self.browser) | ||
| if modal.is_displayed: |
There was a problem hiding this comment.
Mostly following convention in the file for dealing with modals - there isn't a meaningful situation where the modal doesn't pop up, the test should just fail at that point.
There was a problem hiding this comment.
Shouldn't an exception be thrown in that case? Or just handle it somehow, don't leave it in undefined state unless something, somewhere fails?
There was a problem hiding this comment.
I could throw an exception in that case explicitly. It will also always fail if this modal doesn't pop up since the next assertion won't be correct if the modal dialogue isn't interacted with. That's required for the title on the page to change.
There was a problem hiding this comment.
Generally speaking, I don't think this is necessary here.
There was a problem hiding this comment.
It will also always fail if this modal doesn't pop up since the next assertion won't be correct
In your specific test, yes. In any other use, who knows.
|
Please review the PR labels before merging to ensure that the PR gets cherry-picked to the right branches. The same applies to the robottelo PR. |
|
Would like to get this merged so we can run this before go/no go, thanks! |
ogajduse
dismissed
LadislavVasina1’s stale review
To allow merge I am dismissing Ladislav's review as both review comments were addressed.
(cherry picked from commit 9977b6b)
Updates to the traces tab, as well as some support for the new Enable Traces modal. I didn't bother supporting all the possible uses of this modal, as it's not relevant for the current test. This can be added later if more traces tests are desired.