satellite5 installation task refactoring #180
Conversation
lpramuk
force-pushed
the
refactor_sat5_install
branch
from
06049ee
to
b71193d
Compare
| is set then that task will run. | ||
|
|
||
| :param bool create_vm: creates a virtual machine and then install the | ||
| product on it. Default: False. |
There was a problem hiding this comment.
Documentation generators such as Sphinx typically are smart enough to examine the arguments to a method and show the default in the generated docstring. For example, see this method. As a result, writing Default: False. should be unnecessary.
|
Is this task going to be moved in to a separate directory as per this comment? If so, then please add |
| @@ -19,6 +19,7 @@ | |||
| product_install, | |||
| remove_katello_agent, | |||
| run_errata, | |||
| satellite5_product_install, | |||
There was a problem hiding this comment.
I think we can list satellite5_installer here too.
There was a problem hiding this comment.
Ok, then I see more tasks missing, like katello-installer task too.
There was a problem hiding this comment.
Good catch, but other missing tasks should be added in a separated commit or even another PR.
There was a problem hiding this comment.
sure i'm not gonna include these changes in PR
|
ACK, pending comments. |
lpramuk
force-pushed
the
refactor_sat5_install
branch
3 times, most recently
from
951303a
to
aac6969
Compare
|
| # Download and mount the ISO | ||
| print('Downloading ISO...') | ||
| iso_download(iso_url) | ||
| run('umount ISO', warn_only=True) |
|
ACK |
| import os | ||
| import sys | ||
|
|
||
| from automation_tools import install_prerequisites, iso_download, setenforce, \ |
There was a problem hiding this comment.
Please avoid using \, the below example is how we would format that.
from automation_tools import (
install_prerequisites,
iso_download,
setenforce,
setup_ddns,
subscribe,
vm_create,
vm_destroy,
)
|
ACK, pending last comment format. |
lpramuk
force-pushed
the
refactor_sat5_install
branch
from
aac6969
to
795499f
Compare
|
APT |
satellite5 installation task refactoring
|
Karma given. |
created separate satellite5_product_install task that utilizes satellite5_installer (that is renamed and modified satellite5_iso_install task)