Add full compatibility for podman #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broker/helpers.py
Outdated
| @@ -511,8 +512,15 @@ def from_ssh(cls, stdout, channel): | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def from_duplexed_exec(cls, duplex_exec): | |||
| def from_duplexed_exec(cls, duplex_exec, runtime=None): | |||
| """Create a Result object from a duplexed exec object from the docker library.""" | |||
This change fills the gap previously seen for podman's inability execute commands on containers. A large part of this was handling the returned output from podman's exec_run, which is a tuple containing the return code and a bytes string containing both the stdout and stderr. Due to this, we needed to implement a demuxer. Also made some minor tweaks to the functional tests
JacobCallahan
added a commit
that referenced
this pull request
May 29, 2024
This change fills the gap previously seen for podman's inability execute commands on containers. A large part of this was handling the returned output from podman's exec_run, which is a tuple containing the return code and a bytes string containing both the stdout and stderr. Due to this, we needed to implement a demuxer. Also made some minor tweaks to the functional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fills the gap previously seen for podman's inability execute commands on containers.
A large part of this was handling the returned output from podman's exec_run, which is a tuple containing the return code and a bytes string containing both the stdout and stderr.
Due to this, we needed to implement a demuxer.
Also made some minor tweaks to the functional tests