Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated discovery_rule entity with org & location #320

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Updated discovery_rule entity with org & location #320

merged 1 commit into from
Oct 7, 2016

Conversation

sghai
Copy link
Contributor

@sghai sghai commented Oct 3, 2016

No description provided.

@sghai
Copy link
Contributor Author

sghai commented Oct 3, 2016

test results:

In [10]: rule = DiscoveryRule(server_config, name='nailrule12', search_='cpu_count=1', hostgroup='hh_rhel7', location=[loc], organization=[org]).create()

In [11]: rule.name
Out[11]: u'nailrule12'

@coveralls
Copy link

coveralls commented Oct 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 98.472% when pulling 34fc6e1 on sghai:discovery_rule into 9b86c23 on SatelliteQE:master.

@coveralls
Copy link

coveralls commented Oct 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 98.365% when pulling a70f404 on sghai:discovery_rule into 9b86c23 on SatelliteQE:master.

sghai
sghai commented Oct 3, 2016
View reviewed changes
nailgun/entities.py
self._server_config,
id=self.create_json(create_missing)['id'],
).read()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting attribute error with POST & GET so creating entity with create_json(create_missing=True)

sghai
sghai commented Oct 3, 2016
View reviewed changes
nailgun/entities.py
"""
self.update_json(fields)
return self.read()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar issue with PUT request

@elyezer
Copy link
Contributor

elyezer commented Oct 4, 2016

Changes look good to me

@sghai
Copy link
Contributor Author

sghai commented Oct 6, 2016

@oshtaier @abalakh : Hey, please review and help to merge the changes. I thought it already merged. The changes required for tests in SatelliteQE/robottelo/pull/3881

@oshtaier
Copy link
Contributor

oshtaier commented Oct 6, 2016

ACK
@abalakh please, review quickly

@svtkachenko
Copy link
Contributor

ACK but @sghai can you please add this methods to tests? CreateTestCase.test_generic and UpdateTestCase.test_generic should be enough.

@coveralls
Copy link

coveralls commented Oct 7, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 98.533% when pulling 81a49a1 on sghai:discovery_rule into 59d3953 on SatelliteQE:master.

@sghai
Copy link
Contributor Author

sghai commented Oct 7, 2016

@svtkachenko : thank you. Your suggestion fixed the coverage..

@svtkachenko svtkachenko merged commit 40ee56f into SatelliteQE:master Oct 7, 2016
@sghai sghai deleted the discovery_rule branch November 29, 2016 09:02
elyezer added a commit to elyezer/nailgun that referenced this pull request Mar 6, 2017
@elyezer
Release version 0.29.0
4a32630 
Shortlog of commits since last release:

    Andrii Balakhtar (4):
          Fix read() of hostgroup without content_source, lce or cv for 6.1
          Increase timeout for manifest delete/refresh (SatelliteQE#359)
          Provide default name length & type for ComputeResource entities (SatelliteQE#369)
          Implemented Interface entity with all its fields and basic operations (SatelliteQE#373)

    Djebran Lezzoum (1):
          Merge pull request SatelliteQE#380 from svtkachenko/ct_update_payload

    Elyézer Rezende (1):
          Update travis config

    Oleksandr Shtaier (8):
          Merge pull request SatelliteQE#341 from sghai/update-test
          Merge pull request SatelliteQE#342 from renzon/332
          Merge pull request SatelliteQE#344 from elyezer/update-travis
          Merge pull request SatelliteQE#352 from svtkachenko/sv_payload
          Merge pull request SatelliteQE#345 from abalakh/fix_hg_61_workaround
          Merge pull request SatelliteQE#366 from svtkachenko/update_template_kind
          Merge pull request SatelliteQE#361 from svtkachenko/update_sv
          Merge pull request SatelliteQE#383 from svtkachenko/63_image

    Renzo Nuccitelli (3):
          Added json method to Entity (SatelliteQE#326)
          Merge pull request SatelliteQE#347 from svtkachenko/add_image
          Implemented Entity __eq__ method comparing all fields (SatelliteQE#350)

    Stanislav Tkachenko (10):
          Add content related helpers for Repository entity. (SatelliteQE#327)
          Add Create and Delete mixins to Smart Proxy (SatelliteQE#343)
          Add mixins to Image
          Override create_payload and upload_payload for SmartVariable.
          Update Host.puppet_class field name. (SatelliteQE#346)
          Removed overriden read method for Smart Variable
          Update TemplateKind entity
          Add ProvisioningTemplate. (SatelliteQE#365)
          Fix update_payload method for ConfigTemplate/ProvisioningTemplate
          [6.2.z] Update Image and Host entities (SatelliteQE#356)

    oshtaier (2):
          Add UpdateMixin for CV Filter Rules entity
          Add host count field to CV entity

    renzon (5):
          Fixed ConfigTemplate create and update with TemplateCombination
          ListFiled handled on _payload
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination

    sghai (5):
          Updated discovery_rule entity with org & location (SatelliteQE#320)
          Added a new field root_pass to hostgroup entity (SatelliteQE#336)
          Added unit test for root_pass from hostgroup entity
          Merge pull request SatelliteQE#338 from oshtaier/cvf_update_mixin
          Merge pull request SatelliteQE#340 from oshtaier/cv_field
lpramuk pushed a commit to lpramuk/nailgun that referenced this pull request Sep 26, 2023
@sghai @lpramuk
Updated discovery_rule entity with org & location (SatelliteQE#320)
b0330cd
lpramuk pushed a commit to lpramuk/nailgun that referenced this pull request Sep 26, 2023
@elyezer @lpramuk
Release version 0.29.0
96356c1 
Shortlog of commits since last release:

    Andrii Balakhtar (4):
          Fix read() of hostgroup without content_source, lce or cv for 6.1
          Increase timeout for manifest delete/refresh (SatelliteQE#359)
          Provide default name length & type for ComputeResource entities (SatelliteQE#369)
          Implemented Interface entity with all its fields and basic operations (SatelliteQE#373)

    Djebran Lezzoum (1):
          Merge pull request SatelliteQE#380 from svtkachenko/ct_update_payload

    Elyézer Rezende (1):
          Update travis config

    Oleksandr Shtaier (8):
          Merge pull request SatelliteQE#341 from sghai/update-test
          Merge pull request SatelliteQE#342 from renzon/332
          Merge pull request SatelliteQE#344 from elyezer/update-travis
          Merge pull request SatelliteQE#352 from svtkachenko/sv_payload
          Merge pull request SatelliteQE#345 from abalakh/fix_hg_61_workaround
          Merge pull request SatelliteQE#366 from svtkachenko/update_template_kind
          Merge pull request SatelliteQE#361 from svtkachenko/update_sv
          Merge pull request SatelliteQE#383 from svtkachenko/63_image

    Renzo Nuccitelli (3):
          Added json method to Entity (SatelliteQE#326)
          Merge pull request SatelliteQE#347 from svtkachenko/add_image
          Implemented Entity __eq__ method comparing all fields (SatelliteQE#350)

    Stanislav Tkachenko (10):
          Add content related helpers for Repository entity. (SatelliteQE#327)
          Add Create and Delete mixins to Smart Proxy (SatelliteQE#343)
          Add mixins to Image
          Override create_payload and upload_payload for SmartVariable.
          Update Host.puppet_class field name. (SatelliteQE#346)
          Removed overriden read method for Smart Variable
          Update TemplateKind entity
          Add ProvisioningTemplate. (SatelliteQE#365)
          Fix update_payload method for ConfigTemplate/ProvisioningTemplate
          [6.2.z] Update Image and Host entities (SatelliteQE#356)

    oshtaier (2):
          Add UpdateMixin for CV Filter Rules entity
          Add host count field to CV entity

    renzon (5):
          Fixed ConfigTemplate create and update with TemplateCombination
          ListFiled handled on _payload
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination

    sghai (5):
          Updated discovery_rule entity with org & location (SatelliteQE#320)
          Added a new field root_pass to hostgroup entity (SatelliteQE#336)
          Added unit test for root_pass from hostgroup entity
          Merge pull request SatelliteQE#338 from oshtaier/cvf_update_mixin
          Merge pull request SatelliteQE#340 from oshtaier/cv_field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sghai @coveralls @elyezer @oshtaier @svtkachenko