Update Host.puppet_class field name.

[svtkachenko]

Looks like that field host[puppet_class_id] was changed to host[puppetclass_ids], so currently passing puppet_class does nothing when creating/updating host.

puppet_classes = entities.PuppetClass().search(query={
    'search': u'name ~ "generic_1" and environment = "KT_kWtydc_Library_nbVyItrg_60"'})
2016-12-23 00:31:09 - nailgun.client - DEBUG - Making HTTP GET request to https://sat6.com/api/v2/puppetclasses with options {'verify': False, 'data': '{"search": "name ~ \\"generic_1\\" and environment = \\"KT_kWtydc_Library_nbVyItrg_60\\""}', 'auth': ('admin', 'changeme'), 'headers': {'content-type': 'application/json'}} and no data.
2016-12-23 00:31:10 - nailgun.client - DEBUG - Received HTTP 200 response: {
   "results": {"generic_1":[{"id":24,"name":"generic_1","created_at":"2016-12-22T20:53:47.941Z","updated_at":"2016-12-22T20:53:47.941Z"}]}
}

host = entities.Host(
    environment=env.read(),
    puppetclass=puppet_classes,
).create()
2016-12-23 00:31:33 - nailgun.client - DEBUG - Making HTTP POST request to https://sat6.com/api/v2/hosts with options {'verify': False, 'auth': ('admin', 'changeme'), 'headers': {'content-type': 'application/json'}} 
and data .... "puppetclass_ids": [24]}}.
2016-12-23 00:31:34 - nailgun.client - DEBUG - Received HTTP 201 response: {...,
"puppetclasses":[{"id":24,"name":"generic_1","module_name":"generic_1"}],"config_groups":[],"parameters":[],"all_parameters":[],
"all_puppetclasses":[{"id":24,"name":"generic_1","module_name":"generic_1"}],...}

host.puppetclass
<type 'list'>: [nailgun.entities.PuppetClass(nailgun.config.ServerConfig(url='https://example.com', verify=False, auth=('admin', 'changeme')), id=24)]

[coveralls]

Coverage decreased (-0.0007%) to 98.577% when pulling 0784225 on svtkachenko:upd_host into c7a3654 on SatelliteQE:master.

[oshtaier]

What's about attrs['host_parameters_attributes'] = attrs.pop('parameters')?
If that is also fixed, please make a change in one scope and remove corresponding information from docstring

If not, analyze that decrease in test coverage and do corresponding fix

[svtkachenko]

@oshtaier Though bug mentioned in docstring is closed it was only partially fixed: only puppetclass was renamed, host_parameters_attributes still is used for POST and parameters for GET. I'm going to open another BZ.
And decrease in -0.0007% looks like measurement error or rounding error as no new lines were added :)
At least no new lines marked with red in visual coverage.

[abalakh]

ACK. There's nothing new to cover, imo it's issue with travis algorithm as total lines quantity decreased by 1

[sghai]

@svtkachenko : field name changed for specific sat version or affects all ?

[svtkachenko]

@sghai According to apidoc, 6.2 and 6.3 are affected.

[rochacbruno]

@svtkachenko @sghai so we need to cherrypick this to 6.2.z

[svtkachenko]

Shouldn't it be merged to master first? :)

[rochacbruno]

ACK

@svtkachenko please cherry pick this to 6.2.z branch after this merge. :)