Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mixins to Image entity #347

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Add mixins to Image entity #347

merged 1 commit into from
Jan 3, 2017

Conversation

svtkachenko
Copy link
Contributor

No description provided.

@svtkachenko svtkachenko changed the title Add mixins to Image Add mixins to Image entity Dec 23, 2016
@coveralls
Copy link

coveralls commented Dec 23, 2016 •
edited

Coverage Status

Coverage remained the same at 98.578% when pulling 85c7c74 on svtkachenko:add_image into c7a3654 on SatelliteQE:master.

@oshtaier
Copy link
Contributor

Add unit tests for mixins

@svtkachenko svtkachenko mentioned this pull request Dec 23, 2016
Merged
@svtkachenko
Copy link
Contributor Author

@oshtaier Looking into existing tests I think that they are used for entities that override methods from mixins.

@oshtaier
Copy link
Contributor

I would check these two places:
https://github.com/SatelliteQE/nailgun/blob/master/tests/test_entities.py#L482
https://github.com/SatelliteQE/nailgun/blob/master/tests/test_entities.py#L1142

@svtkachenko
Copy link
Contributor Author

Yeap, checked that before writing previous comment.
CreateTestCase: the list of added entities is much smaller than entire list of entities, all added entities except ConfigGroup have overridden create or create_payload method.
UpdateTestCase: the list of added entities is much smaller than entire list of entities, all added entities have overridden update or update_payload method.

It is not so difficult to add another entity to the tests thanks to its good design, however bloated code is prone to errors so better keep it compacted.
Also @coveralls says that Coverage remained the same.

renzon
renzon approved these changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@renzon renzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@renzon renzon merged commit ba008a5 into SatelliteQE:master Jan 3, 2017
@renzon renzon removed the review label Jan 3, 2017
@svtkachenko svtkachenko mentioned this pull request Jan 17, 2017
Merged
rochacbruno pushed a commit that referenced this pull request Jan 23, 2017
@svtkachenko @rochacbruno
[6.2.z] Update Image and Host entities (#356)
1faf7f4 
* Merge pull request #347 from svtkachenko/add_image

Add mixins to Image entity

* Update Image class.

* Changes specific for 6.2
elyezer added a commit to elyezer/nailgun that referenced this pull request Mar 6, 2017
@elyezer
Release version 0.29.0
4a32630 
Shortlog of commits since last release:

    Andrii Balakhtar (4):
          Fix read() of hostgroup without content_source, lce or cv for 6.1
          Increase timeout for manifest delete/refresh (SatelliteQE#359)
          Provide default name length & type for ComputeResource entities (SatelliteQE#369)
          Implemented Interface entity with all its fields and basic operations (SatelliteQE#373)

    Djebran Lezzoum (1):
          Merge pull request SatelliteQE#380 from svtkachenko/ct_update_payload

    Elyézer Rezende (1):
          Update travis config

    Oleksandr Shtaier (8):
          Merge pull request SatelliteQE#341 from sghai/update-test
          Merge pull request SatelliteQE#342 from renzon/332
          Merge pull request SatelliteQE#344 from elyezer/update-travis
          Merge pull request SatelliteQE#352 from svtkachenko/sv_payload
          Merge pull request SatelliteQE#345 from abalakh/fix_hg_61_workaround
          Merge pull request SatelliteQE#366 from svtkachenko/update_template_kind
          Merge pull request SatelliteQE#361 from svtkachenko/update_sv
          Merge pull request SatelliteQE#383 from svtkachenko/63_image

    Renzo Nuccitelli (3):
          Added json method to Entity (SatelliteQE#326)
          Merge pull request SatelliteQE#347 from svtkachenko/add_image
          Implemented Entity __eq__ method comparing all fields (SatelliteQE#350)

    Stanislav Tkachenko (10):
          Add content related helpers for Repository entity. (SatelliteQE#327)
          Add Create and Delete mixins to Smart Proxy (SatelliteQE#343)
          Add mixins to Image
          Override create_payload and upload_payload for SmartVariable.
          Update Host.puppet_class field name. (SatelliteQE#346)
          Removed overriden read method for Smart Variable
          Update TemplateKind entity
          Add ProvisioningTemplate. (SatelliteQE#365)
          Fix update_payload method for ConfigTemplate/ProvisioningTemplate
          [6.2.z] Update Image and Host entities (SatelliteQE#356)

    oshtaier (2):
          Add UpdateMixin for CV Filter Rules entity
          Add host count field to CV entity

    renzon (5):
          Fixed ConfigTemplate create and update with TemplateCombination
          ListFiled handled on _payload
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination

    sghai (5):
          Updated discovery_rule entity with org & location (SatelliteQE#320)
          Added a new field root_pass to hostgroup entity (SatelliteQE#336)
          Added unit test for root_pass from hostgroup entity
          Merge pull request SatelliteQE#338 from oshtaier/cvf_update_mixin
          Merge pull request SatelliteQE#340 from oshtaier/cv_field
@svtkachenko svtkachenko deleted the add_image branch August 22, 2017 14:52
lpramuk pushed a commit to lpramuk/nailgun that referenced this pull request Sep 26, 2023
@svtkachenko @lpramuk
[6.2.z] Update Image and Host entities (SatelliteQE#356)
9dd25c9 
* Merge pull request SatelliteQE#347 from svtkachenko/add_image

Add mixins to Image entity

* Update Image class.

* Changes specific for 6.2
lpramuk pushed a commit to lpramuk/nailgun that referenced this pull request Sep 26, 2023
@elyezer @lpramuk
Release version 0.29.0
96356c1 
Shortlog of commits since last release:

    Andrii Balakhtar (4):
          Fix read() of hostgroup without content_source, lce or cv for 6.1
          Increase timeout for manifest delete/refresh (SatelliteQE#359)
          Provide default name length & type for ComputeResource entities (SatelliteQE#369)
          Implemented Interface entity with all its fields and basic operations (SatelliteQE#373)

    Djebran Lezzoum (1):
          Merge pull request SatelliteQE#380 from svtkachenko/ct_update_payload

    Elyézer Rezende (1):
          Update travis config

    Oleksandr Shtaier (8):
          Merge pull request SatelliteQE#341 from sghai/update-test
          Merge pull request SatelliteQE#342 from renzon/332
          Merge pull request SatelliteQE#344 from elyezer/update-travis
          Merge pull request SatelliteQE#352 from svtkachenko/sv_payload
          Merge pull request SatelliteQE#345 from abalakh/fix_hg_61_workaround
          Merge pull request SatelliteQE#366 from svtkachenko/update_template_kind
          Merge pull request SatelliteQE#361 from svtkachenko/update_sv
          Merge pull request SatelliteQE#383 from svtkachenko/63_image

    Renzo Nuccitelli (3):
          Added json method to Entity (SatelliteQE#326)
          Merge pull request SatelliteQE#347 from svtkachenko/add_image
          Implemented Entity __eq__ method comparing all fields (SatelliteQE#350)

    Stanislav Tkachenko (10):
          Add content related helpers for Repository entity. (SatelliteQE#327)
          Add Create and Delete mixins to Smart Proxy (SatelliteQE#343)
          Add mixins to Image
          Override create_payload and upload_payload for SmartVariable.
          Update Host.puppet_class field name. (SatelliteQE#346)
          Removed overriden read method for Smart Variable
          Update TemplateKind entity
          Add ProvisioningTemplate. (SatelliteQE#365)
          Fix update_payload method for ConfigTemplate/ProvisioningTemplate
          [6.2.z] Update Image and Host entities (SatelliteQE#356)

    oshtaier (2):
          Add UpdateMixin for CV Filter Rules entity
          Add host count field to CV entity

    renzon (5):
          Fixed ConfigTemplate create and update with TemplateCombination
          ListFiled handled on _payload
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination

    sghai (5):
          Updated discovery_rule entity with org & location (SatelliteQE#320)
          Added a new field root_pass to hostgroup entity (SatelliteQE#336)
          Added unit test for root_pass from hostgroup entity
          Merge pull request SatelliteQE#338 from oshtaier/cvf_update_mixin
          Merge pull request SatelliteQE#340 from oshtaier/cv_field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renzon renzon renzon approved these changes

@oshtaier oshtaier oshtaier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@svtkachenko @coveralls @oshtaier @renzon