Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read() of hostgroup without content_source, lce or cv for sat6.1 #345

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Fix read() of hostgroup without content_source, lce or cv for sat6.1 #345

merged 1 commit into from
Jan 17, 2017

Conversation

abalakh
Copy link
Contributor

@abalakh abalakh commented Dec 22, 2016 •
edited by rochacbruno

Resolves #279
Issue is pretty old, i'd even think of removing such workaround, but just in case somebody is using sat6.1 with latest nailgun - fix is very trivial.

@abalakh abalakh changed the title Fix read() of hostgroup without content_source, lce or cv for 6.1 Fix read() of hostgroup without content_source, lce or cv for sat6.1 Dec 22, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.578% when pulling a25d2cf on abalakh:fix_hg_61_workaround into c7a3654 on SatelliteQE:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.578% when pulling a25d2cf on abalakh:fix_hg_61_workaround into c7a3654 on SatelliteQE:master.

rochacbruno
rochacbruno approved these changes Dec 22, 2016
View reviewed changes
Copy link
Contributor

@rochacbruno rochacbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@oshtaier
Copy link
Contributor

ACK pending any test result for at least 6.3, but 6.1 will be also pretty good

@abalakh
Copy link
Contributor Author

abalakh commented Dec 27, 2016

@oshtaier the change is inside a block for 6.1 only, there's no point in 6.3 results here (except of syntax error maybe, which is not the case).

@abalakh
Copy link
Contributor Author

abalakh commented Jan 16, 2017

Sat 6.1:

>>> from nailgun import config, entities
>>> cfg = config.ServerConfig('https://example1.redhat.com', version='6.1.0', auth=('admin', 'secretpassword'), verify=False)
>>> hg = entities.HostGroup(cfg).create(True)
>>> hg.read()
nailgun.entities.HostGroup(nailgun.config.ServerConfig(url='https://example1.redhat.com', verify=False, version='6.1.0', auth=('admin', 'secretpassword')), domain=None, medium=None, parent=None, ptable=None, content_source=None, lifecycle_environment=None, operatingsystem=None, name=u'mFrpqpUPkHFT', subnet=None, puppet_proxy=None, realm=None, content_view=None, id=1, environment=None, location=[], organization=[], puppet_ca_proxy=None, architecture=None)

Sat 6.3:

>>> cfg630 = config.ServerConfig('https://example2.redhat.com', version='6.3.0', auth=('admin', 'secretpassword'), verify=False)
>>> hg = entities.HostGroup(cfg630).create(True)
>>> hg.read()
nailgun.entities.HostGroup(nailgun.config.ServerConfig(url='https://example2.redhat.com', verify=False, version='6.3.0', auth=('admin', 'secretpassword')), domain=None, medium=None, parent=None, ptable=None, content_source=None, lifecycle_environment=None, operatingsystem=None, name=u'iZIbMEIldFM', subnet=None, puppet_proxy=None, realm=None, content_view=None, id=1, environment=None, location=[], organization=[], puppet_ca_proxy=None, architecture=None)

@oshtaier
Copy link
Contributor

ACK

@oshtaier oshtaier merged commit ecfa908 into SatelliteQE:master Jan 17, 2017
@oshtaier oshtaier removed the review label Jan 17, 2017
@abalakh abalakh deleted the fix_hg_61_workaround branch January 17, 2017 09:29
elyezer added a commit to elyezer/nailgun that referenced this pull request Mar 6, 2017
@elyezer
Release version 0.29.0
4a32630 
Shortlog of commits since last release:

    Andrii Balakhtar (4):
          Fix read() of hostgroup without content_source, lce or cv for 6.1
          Increase timeout for manifest delete/refresh (SatelliteQE#359)
          Provide default name length & type for ComputeResource entities (SatelliteQE#369)
          Implemented Interface entity with all its fields and basic operations (SatelliteQE#373)

    Djebran Lezzoum (1):
          Merge pull request SatelliteQE#380 from svtkachenko/ct_update_payload

    Elyézer Rezende (1):
          Update travis config

    Oleksandr Shtaier (8):
          Merge pull request SatelliteQE#341 from sghai/update-test
          Merge pull request SatelliteQE#342 from renzon/332
          Merge pull request SatelliteQE#344 from elyezer/update-travis
          Merge pull request SatelliteQE#352 from svtkachenko/sv_payload
          Merge pull request SatelliteQE#345 from abalakh/fix_hg_61_workaround
          Merge pull request SatelliteQE#366 from svtkachenko/update_template_kind
          Merge pull request SatelliteQE#361 from svtkachenko/update_sv
          Merge pull request SatelliteQE#383 from svtkachenko/63_image

    Renzo Nuccitelli (3):
          Added json method to Entity (SatelliteQE#326)
          Merge pull request SatelliteQE#347 from svtkachenko/add_image
          Implemented Entity __eq__ method comparing all fields (SatelliteQE#350)

    Stanislav Tkachenko (10):
          Add content related helpers for Repository entity. (SatelliteQE#327)
          Add Create and Delete mixins to Smart Proxy (SatelliteQE#343)
          Add mixins to Image
          Override create_payload and upload_payload for SmartVariable.
          Update Host.puppet_class field name. (SatelliteQE#346)
          Removed overriden read method for Smart Variable
          Update TemplateKind entity
          Add ProvisioningTemplate. (SatelliteQE#365)
          Fix update_payload method for ConfigTemplate/ProvisioningTemplate
          [6.2.z] Update Image and Host entities (SatelliteQE#356)

    oshtaier (2):
          Add UpdateMixin for CV Filter Rules entity
          Add host count field to CV entity

    renzon (5):
          Fixed ConfigTemplate create and update with TemplateCombination
          ListFiled handled on _payload
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination

    sghai (5):
          Updated discovery_rule entity with org & location (SatelliteQE#320)
          Added a new field root_pass to hostgroup entity (SatelliteQE#336)
          Added unit test for root_pass from hostgroup entity
          Merge pull request SatelliteQE#338 from oshtaier/cvf_update_mixin
          Merge pull request SatelliteQE#340 from oshtaier/cv_field
lpramuk pushed a commit to lpramuk/nailgun that referenced this pull request Sep 26, 2023
@elyezer @lpramuk
Release version 0.29.0
96356c1 
Shortlog of commits since last release:

    Andrii Balakhtar (4):
          Fix read() of hostgroup without content_source, lce or cv for 6.1
          Increase timeout for manifest delete/refresh (SatelliteQE#359)
          Provide default name length & type for ComputeResource entities (SatelliteQE#369)
          Implemented Interface entity with all its fields and basic operations (SatelliteQE#373)

    Djebran Lezzoum (1):
          Merge pull request SatelliteQE#380 from svtkachenko/ct_update_payload

    Elyézer Rezende (1):
          Update travis config

    Oleksandr Shtaier (8):
          Merge pull request SatelliteQE#341 from sghai/update-test
          Merge pull request SatelliteQE#342 from renzon/332
          Merge pull request SatelliteQE#344 from elyezer/update-travis
          Merge pull request SatelliteQE#352 from svtkachenko/sv_payload
          Merge pull request SatelliteQE#345 from abalakh/fix_hg_61_workaround
          Merge pull request SatelliteQE#366 from svtkachenko/update_template_kind
          Merge pull request SatelliteQE#361 from svtkachenko/update_sv
          Merge pull request SatelliteQE#383 from svtkachenko/63_image

    Renzo Nuccitelli (3):
          Added json method to Entity (SatelliteQE#326)
          Merge pull request SatelliteQE#347 from svtkachenko/add_image
          Implemented Entity __eq__ method comparing all fields (SatelliteQE#350)

    Stanislav Tkachenko (10):
          Add content related helpers for Repository entity. (SatelliteQE#327)
          Add Create and Delete mixins to Smart Proxy (SatelliteQE#343)
          Add mixins to Image
          Override create_payload and upload_payload for SmartVariable.
          Update Host.puppet_class field name. (SatelliteQE#346)
          Removed overriden read method for Smart Variable
          Update TemplateKind entity
          Add ProvisioningTemplate. (SatelliteQE#365)
          Fix update_payload method for ConfigTemplate/ProvisioningTemplate
          [6.2.z] Update Image and Host entities (SatelliteQE#356)

    oshtaier (2):
          Add UpdateMixin for CV Filter Rules entity
          Add host count field to CV entity

    renzon (5):
          Fixed ConfigTemplate create and update with TemplateCombination
          ListFiled handled on _payload
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination
          api fixed and methods GET and DELETED added for TemplateCombination

    sghai (5):
          Updated discovery_rule entity with org & location (SatelliteQE#320)
          Added a new field root_pass to hostgroup entity (SatelliteQE#336)
          Added unit test for root_pass from hostgroup entity
          Merge pull request SatelliteQE#338 from oshtaier/cvf_update_mixin
          Merge pull request SatelliteQE#340 from oshtaier/cv_field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochacbruno rochacbruno rochacbruno approved these changes

@oshtaier oshtaier Awaiting requested review from oshtaier

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read hostgroups without content_source, content_view or lifecycle_environment
4 participants
@abalakh @coveralls @oshtaier @rochacbruno