AST created with tree_from_a2l() does not contain layout for measurements.

[LuDubies]

Missing LAYOUT property for measurements

When parsing A2L measurement objects, the ast does not contain layout information.

The property seems correctly defined in a2l-grpc/grammar/A2L.g4

Reproduce

When using the A2LParser.tree_from_a2l() on the attached dumb.txt (convert to .a2l), the properties of the "Dumbo" measurement contain no LAYOUT.
dumb.txt

This happens with a newly build pya2l and newest artifacts from a2l-grpc

[LuDubies]

When comparing protobuf/A2L.proto to the ANTLR definition, the measurement type is missing the 4 properties:

• discrete
• layout
• physUnit
• symbolLink

The same is true for the AxisPts and Characteristic Types (physUnit & symbolLink)

[LuDubies]

might close here and reopen in the a2l-grpc repo.

[Sauci]

Hi @LuDubies , thanks for the detailed feedback and the time, I'm on it :) Indeed those nodes are present in the grammar but not in the exchange protocol. The reason for that is because I'm used to have A2Ls with older ASAP2 version, where those nodes are not defined. I will fix it, and will close this issue once you will be able to parse your input as expected, is it ok for you?

[Sauci]

@LuDubies it should be fixed in version 0.1.1. Could you confirm please? Thanks in advance for your feedback!

[LuDubies]

Hey @Sauci, thank you for the quick work.
I managed to extend the listener on friday but did not find the time to create a pull request.
Sorry that I had you do the same work again, but very grateful for the quick reaction.

I will check out your 0.1.1 release on wednesday and then we can close this.

[LuDubies]

Checking out the diffs for b9c4627, it looks like it should fix my issue and more. Can propably close this without me testing it again :)

Thanks again for your work, appreciate the project!

[LuDubies]

Working with pya2l version 0.1.1 now, the issue has been fixed as predicted.
Just leaving this comment as confirmation.