Generate volume sliders from project buses #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding a Music and SFX bus, this will instead generate sliders based on the audio buses already defined in the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding a Music and SFX bus, this will instead generate sliders based on the audio buses already defined in the project, including the master bus. The labels will display "{Bus Name} Volume".
I'm making this change because when I was trying to implement into my already existing project, I had more audio buses than just Music and Sfx, and it was a little bit of a chore to add new volume sliders and change the existing ones.
This new system should be more flexible, but comes at the downside that the user will have to make changes to the slider node separately from the main options menu scene.