Import more modules #488
Draft
Import more modules #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `stShortModuleNames` (for sbt plugin) and `--shortModuleNames` for CLI which reverts to old behaviour. Note that the old behaviour is deprecated
So far ST has looked at package.json to determine a subset of typings to include. Going forward *all* files will be translated. This solves #463 There are loads of details for computing shorter module names. These will be solved similar to how `exports` was solved in #486, by injecting "proxy modules" into the AST. Note that some libraries ship typings for multiple hierarchies, typically in folders named `src`, `es`, `es6` and so on. we'll now get all those duplicates as well.
oyvindberg
force-pushed
the
import-all-modules
branch
from
3c0e8ce
to
d7ae3ae
Compare
oyvindberg
force-pushed
the
predictable-module-names
branch
from
e91b838
to
317b19f
Compare
oyvindberg
force-pushed
the
master
branch
2 times, most recently
from
d3bbca8
to
ad9f226
Compare
This was referenced Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far ST has looked at package.json to determine a subset of typings to include. Going forward all files will be translated. This solves #463
There are loads of details for computing shorter module names. These will be solved similar to how
exportswas solved in #486, by injecting "proxy modules" into the AST.Note that some libraries ship typings for multiple hierarchies, typically in folders named
src,es,es6and so on. we'll now get all those duplicates as well.