Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(error): invalid return on IsOtpError #371

Merged
merged 2 commits into from
Feb 12, 2024
Merged

fix(error): invalid return on IsOtpError #371

merged 2 commits into from
Feb 12, 2024

Conversation

ipfaze
Copy link
Contributor

@ipfaze ipfaze commented Jan 16, 2024 •
edited by curzolapierre
Loading

@ipfaze ipfaze marked this pull request as draft January 17, 2024 08:56
@EtienneM EtienneM changed the title fix(error): invalid return on IsOtpError Fix https://github.com/Scalingo/cli/issues/1029 fix(error): invalid return on IsOtpError Jan 23, 2024
@curzolapierre curzolapierre force-pushed the fix/cli#1029/authentication_with_2FA branch 3 times, most recently from 9463ebc to bee4847 Compare February 12, 2024 13:38
@curzolapierre curzolapierre marked this pull request as ready for review February 12, 2024 13:38
@curzolapierre curzolapierre force-pushed the fix/cli#1029/authentication_with_2FA branch from bee4847 to ca7fe36 Compare February 12, 2024 13:39
EtienneM
EtienneM reviewed Feb 12, 2024
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: thanks for taking over this issue 🙏

question: did you tested it in the CLI to ensure it fixes the issue?

http/errors.go Outdated
@@ -9,6 +9,7 @@ import (
"gopkg.in/errgo.v1"

"github.com/Scalingo/go-scalingo/v6/debug"
scErrors "github.com/Scalingo/go-utils/errors/v2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: in order to match Scalingo convention

Suggested change
scErrors "github.com/Scalingo/go-utils/errors/v2"
errorspkg "github.com/Scalingo/go-utils/errors/v2"

http/errors_test.go Show resolved Hide resolved
@curzolapierre curzolapierre force-pushed the fix/cli#1029/authentication_with_2FA branch from ca7fe36 to cbf5e99 Compare February 12, 2024 13:58
@curzolapierre curzolapierre force-pushed the fix/cli#1029/authentication_with_2FA branch from cbf5e99 to 94a6965 Compare February 12, 2024 14:00
@curzolapierre
Copy link
Member

@EtienneM Yes I've tested with the CLI, it solves the related issue

EtienneM
EtienneM approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@curzolapierre curzolapierre merged commit f7f2be8 into master Feb 12, 2024
2 checks passed
@curzolapierre curzolapierre deleted the fix/cli#1029/authentication_with_2FA branch February 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curzolapierre curzolapierre curzolapierre left review comments

@EtienneM EtienneM EtienneM approved these changes

Assignees

@ipfaze ipfaze

@SCedricThomas SCedricThomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't login with password if two-factor auth is enabled
4 participants
@ipfaze @curzolapierre @EtienneM @SCedricThomas