SCALRCORE-18723 Fix Provider to handle 404 error

Scalr · Sep 2, 2021 · 9ac71df · 9ac71df
1 parent 89c9dd2
commit 9ac71df
Showing 1 changed file with 20 additions and 8 deletions.
diff --git a/scalr_test.go b/scalr_test.go
@@ -248,16 +248,28 @@ func TestClient_retryHTTPCheck(t *testing.T) {
 	}
 }
 
-func TestClient_notFoundErrorWithoutMessage(t *testing.T) {
-	resp := &http.Response{
-		StatusCode: 404,
-		Body:       ioutil.NopCloser(bytes.NewBufferString("test boody")),
+func TestClient_errorWithoutMessage(t *testing.T) {
+	cases := map[string]struct {
+		resp *http.Response
+		err  error
+	}{
+		"404-not-found-error": {
+			resp: &http.Response{StatusCode: 404, Body: ioutil.NopCloser(bytes.NewBufferString("test body"))},
+			err:  ErrResourceNotFound{},
+		},
+		"500-server-error": {
+			resp: &http.Response{StatusCode: 500, Body: ioutil.NopCloser(bytes.NewBufferString("test body"))},
+			err:  errors.New(""),
+		},
 	}
-	err := checkResponseCode(resp)
 
-	if err != nil {
-		assert.Error(t, err)
-		assert.Equal(t, err, ErrResourceNotFound{})
+	for _, tc := range cases {
+		err := checkResponseCode(tc.resp)
+
+		if err != nil {
+			assert.Error(t, err)
+			assert.Equal(t, err, tc.err)
+		}
 	}
 }